From: Janosch Frank <frankja@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com,
thuth@redhat.com, imbrenda@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, wintera@linux.ibm.com, seiden@linux.ibm.com,
nrb@linux.ibm.com, scgl@linux.ibm.com
Subject: Re: [PATCH v13 2/2] KVM: s390: resetting the Topology-Change-Report
Date: Thu, 14 Jul 2022 16:12:00 +0200 [thread overview]
Message-ID: <541d85d3-4864-583c-ff33-d0f566770c9f@linux.ibm.com> (raw)
In-Reply-To: <20220714101824.101601-3-pmorel@linux.ibm.com>
On 7/14/22 12:18, Pierre Morel wrote:
> During a subsystem reset the Topology-Change-Report is cleared.
>
> Let's give userland the possibility to clear the MTCR in the case
> of a subsystem reset.
>
> To migrate the MTCR, we give userland the possibility to
> query the MTCR state.
>
> We indicate KVM support for the CPU topology facility with a new
> KVM capability: KVM_CAP_S390_CPU_TOPOLOGY.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Nit below, but:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -1158,6 +1158,7 @@ struct kvm_ppc_resize_hpt {
> #define KVM_CAP_SYSTEM_EVENT_DATA 215
> #define KVM_CAP_ARM_SYSTEM_SUSPEND 216
> #define KVM_CAP_S390_PROTECTED_DUMP 217
> +#define KVM_CAP_S390_CPU_TOPOLOGY 218
> #define KVM_CAP_S390_ZPCI_OP 221
Using 222 and moving it a line down might make more sense as 218 is
KVM_CAP_X86_TRIPLE_FAULT_EVENT.
Can you fix this and push both patches to devel?
Also send the fixed patch as a reply to this message so I can pick it
from the list.
next and devel have diverted a bit so I will need to fix this up for
next, same for the Documentation entry which will be 6.39 instead of 6.38.
>
> #ifdef KVM_CAP_IRQ_ROUTING
next prev parent reply other threads:[~2022-07-14 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 10:18 [PATCH v13 0/2] s390x: KVM: CPU Topology Pierre Morel
2022-07-14 10:18 ` [PATCH v13 1/2] KVM: s390: guest support for topology function Pierre Morel
2022-07-14 10:18 ` [PATCH v13 2/2] KVM: s390: resetting the Topology-Change-Report Pierre Morel
2022-07-14 14:12 ` Janosch Frank [this message]
2022-07-14 19:43 ` Pierre Morel
2022-07-19 12:09 ` [PATCH v13 0/2] s390x: KVM: CPU Topology Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541d85d3-4864-583c-ff33-d0f566770c9f@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=scgl@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.