From: Steve Dickson <SteveD@redhat.com>
To: myllynen@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsstat: fix server rpc stats header
Date: Wed, 22 Oct 2014 11:33:52 -0400 [thread overview]
Message-ID: <5447CE60.2020202@RedHat.com> (raw)
In-Reply-To: <544499BA.1050408@redhat.com>
On 10/20/2014 01:12 AM, Marko Myllynen wrote:
> linux/net/sunrpc/stats.c has:
>
> /*
> * Get RPC server stats
> */
> void svc_seq_show(struct seq_file *seq, const struct svc_stat *statp) {
> ...
> seq_printf(seq,
> "rpc %u %u %u %u %u\n",
> statp->rpccnt,
> statp->rpcbadfmt+statp->rpcbadauth+statp->rpcbadclnt,
> statp->rpcbadfmt,
> statp->rpcbadauth,
> statp->rpcbadclnt);
> ...
>
> But when /proc/net/rpc/nfsd contains
>
> rpc 1 2 3 4 5
>
> nfsstat -sv prints:
>
> Server rpc stats:
> calls badcalls badclnt badauth xdrcall
> 1 2 3 4 5
>
> Change this to match the kernel:
>
> Server rpc stats:
> calls badcalls badfmt badauth badclnt
> 1 2 3 4 5
>
> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1142842.
>
> Signed-off-by: Marko Myllynen <myllynen@redhat.com>
Committed....
steved.
> ---
> utils/nfsstat/nfsstat.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
> index 18e4d27..9f481db 100644
> --- a/utils/nfsstat/nfsstat.c
> +++ b/utils/nfsstat/nfsstat.c
> @@ -558,7 +558,7 @@ print_server_stats(int opt_prt)
> ;
> } else {
> print_numbers(LABEL_srvrpc
> - "calls badcalls badclnt badauth xdrcall\n",
> + "calls badcalls badfmt badauth badclnt\n",
> srvrpcinfo, 5);
> printf("\n");
> }
>
prev parent reply other threads:[~2014-10-22 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 5:12 [PATCH] nfsstat: fix server rpc stats header Marko Myllynen
2014-10-21 10:35 ` Christoph Hellwig
2014-10-22 15:33 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447CE60.2020202@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=myllynen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.