From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: shr@devkernel.io, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mm: fix arithmetic for max_prop_frac when setting max_ratio
Date: Tue, 19 Dec 2023 13:58:21 +0800 [thread overview]
Message-ID: <5460aaf1-44f6-475f-b980-cb9058cc1df4@linux.alibaba.com> (raw)
In-Reply-To: <ZYEWyn5g/jG/ixMk@casper.infradead.org>
On 12/19/23 12:06 PM, Matthew Wilcox wrote:
> On Tue, Dec 19, 2023 at 10:42:46AM +0800, Jingbo Xu wrote:
>> } else {
>> bdi->max_ratio = max_ratio;
>> - bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) / 100;
>> + bdi->max_prop_frac = div64_u64(FPROP_FRAC_BASE * max_ratio,
>> + 100 * BDI_RATIO_SCALE);
>> }
>
> Why use div64_u64 here?
>
> FPROP_FRAC_BASE is an unsigned long. max_ratio is an unsigned int, so
> the numerator is an unsigned long. BDI_RATIO_SCALE is 10,000, so the
> numerator is an unsigned int. There's no 64-bit arithmetic needed here.
Yes, div64_u64() is actually not needed here. So it seems
bdi->max_prop_frac = FPROP_FRAC_BASE * max_ratio / 100 / BDI_RATIO_SCALE;
is adequate?
--
Thanks,
Jingbo
next prev parent reply other threads:[~2023-12-19 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 2:42 [PATCH v2 0/2] mm: fix arithmetic for bdi min_ratio and Jingbo Xu
2023-12-19 2:42 ` [PATCH v2 1/2] mm: fix arithmetic for bdi min_ratio Jingbo Xu
2023-12-19 2:42 ` [PATCH v2 2/2] mm: fix arithmetic for max_prop_frac when setting max_ratio Jingbo Xu
2023-12-19 4:06 ` Matthew Wilcox
2023-12-19 5:58 ` Jingbo Xu [this message]
2023-12-19 13:01 ` Matthew Wilcox
2023-12-19 14:07 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460aaf1-44f6-475f-b980-cb9058cc1df4@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shr@devkernel.io \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.