Re: [PATCH 1/4] drm/doc: Helpers are not a Midlayer!

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/doc: Helpers are not a Midlayer!
Date: Thu, 01 Nov 2012 12:25:18 +0100	[thread overview]
Message-ID: <5463881.is76t5Nm0S@avalon> (raw)
In-Reply-To: <1351674710-11629-1-git-send-email-daniel.vetter@ffwll.ch>

Hi Daniel,

Thanks for the patch.

On Wednesday 31 October 2012 10:11:47 Daniel Vetter wrote:
> I'm devoting all my wrath to that fight, so don't misname it ;-)

Right, my bad :-)

> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  Documentation/DocBook/drm.tmpl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index b030052..ca45155 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -1621,10 +1621,10 @@ void intel_crt_init(struct drm_device *dev)
>      </sect2>
>    </sect1>
> 
> -  <!-- Internals: mid-layer helper functions -->
> +  <!-- Internals: helper functions -->

Do you think we should come up with a more descriptive name ? We have 
different sets of helpers, what would you call this one ? Mode Set Helper 
Functions ?

>    <sect1>
> -    <title>Mid-layer Helper Functions</title>
> +    <title>Helper Functions</title>
>      <para>
>        The CRTC, encoder and connector functions provided by the drivers
>        implement the DRM API. They're called by the DRM core and ioctl
> handlers

-- 
Regards,

Laurent Pinchart