Re: [PATCH 21/30] ALSA: oxfw: Change the way to name card

From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: clemens@ladisch.de, alsa-devel@alsa-project.org,
	ffado-devel@lists.sourceforge.net
Subject: Re: [PATCH 21/30] ALSA: oxfw: Change the way to name card
Date: Mon, 01 Dec 2014 23:58:43 +0900	[thread overview]
Message-ID: <547C8223.4070402@sakamocchi.jp> (raw)
In-Reply-To: <s5hzjb792z3.wl-tiwai@suse.de>

On Dec 1 2014 17:41, Takashi Iwai wrote:
> At Mon, 01 Dec 2014 08:19:14 +0900,
> Takashi Sakamoto wrote:
>>
>> On Nov 30 2013 17:31, Takashi Iwai wrote:
>>>>> So, this ends up with the identical strings for both driver and
>>>>> shortname?  This doesn't sound like an improvement.
>>>>
>>>> Basically, hard-coded strings can be replaced by strings read from
>>>> config-rom on the devices. My original intension of this commit is
>>>> following to this.
>>>>
>>>> But FWSpeakers/FireWave has long strings for vendor/model strings on
>>>> config-rom, therefore his commit can obsolete long name only.
>>>>
>>>> Actually this patch is a help for later patch:
>>>> [PATCH 26/30] ALSA: oxfw: Add support for Behringer/Mackie devices
>>>> http://mailman.alsa-project.org/pipermail/alsa-devel/2014-November/084818.html
>>>
>>> But still it's not applied to LaCie and other that have device_info,
>>> no?  So they'll end up with the even shorter names than now.
>>>
>>> I'd be better to create a short_name from "Vendor Model" where
>>> driver_name can be a fallback of model name.
>>
>> Any reasons?
> 
> Read again: it'll be "shorter name than now".

I think this is a description, and

> Basically it's strange to have a very same string for both driver and
> shrotname.  The shortname is a more detailed description usually
> including both vendor and model names while the driver is the unique
> identifier string.

this is a reason, your intension. This is what I required because I
didn't understand why you insist.

There is just a comment, '/* short name of this soundcard */' in
include/sound/core.h or '/* Short name of soundcard */' in
include/uapi/sound/asound.h. There is no hint for how I should define
the shortname.

Well, I don't mind to use 'Vendor Model' style for shortname. This is
also good for identical names such as 'hw:FireWave' because the last
word of shortname is used for the identical name. Therefore I don't like
to use reverse combination, 'Model Vendor' style, such as 'HDA Intel'.

Regards

Takashi Sakamoto
o-takashi@sakamocchi.jp