From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-mips@linux-mips.org
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
mpm@selenic.com, herbert@gondor.apana.org.au, wsa@the-dreams.de,
cernekee@gmail.com
Subject: Re: [PATCH 2/4] hw_random: bcm63xx-rng: move register definitions to driver
Date: Tue, 17 Feb 2015 14:35:20 +0300 [thread overview]
Message-ID: <54E32778.3060307@cogentembedded.com> (raw)
In-Reply-To: <1424138956-11563-3-git-send-email-f.fainelli@gmail.com>
Hello.
On 2/17/2015 5:09 AM, Florian Fainelli wrote:
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h contains the register
> definitions for this random number generator block, incorporate these
> register definitions directly into the bcm63xx-rng driver so we do not
> rely on this header to be provided.
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/char/hw_random/bcm63xx-rng.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
> diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
> index ed9b28b35a39..c7f3af852599 100644
> --- a/drivers/char/hw_random/bcm63xx-rng.c
> +++ b/drivers/char/hw_random/bcm63xx-rng.c
> @@ -13,7 +13,15 @@
> #include <linux/platform_device.h>
> #include <linux/hw_random.h>
>
> -#include <bcm63xx_regs.h>
> +#define RNG_CTRL 0x00
> +#define RNG_EN (1 << 0)
> +
> +#define RNG_STAT 0x04
> +#define RNG_AVAIL_MASK (0xff000000)
Parens not needed here.
WBR, Sergei
next prev parent reply other threads:[~2015-02-17 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 2:09 [PATCH 0/4] hw_random: bcm63xx-rng: misc cleanups and reorg Florian Fainelli
2015-02-17 2:09 ` [PATCH 1/4] hw_random: bcm63xx-rng: drop bcm_{readl,writel} macros Florian Fainelli
2015-02-17 2:09 ` [PATCH 2/4] hw_random: bcm63xx-rng: move register definitions to driver Florian Fainelli
2015-02-17 11:35 ` Sergei Shtylyov [this message]
2015-02-17 2:09 ` [PATCH 3/4] MIPS: BCM63xx: remove RSET_RNG register definitions Florian Fainelli
2015-02-17 2:09 ` [PATCH 4/4] hw_random: bcm63xx-rng: use devm_* helpers Florian Fainelli
2015-03-01 10:03 ` [PATCH 0/4] hw_random: bcm63xx-rng: misc cleanups and reorg Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E32778.3060307@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=cernekee@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mpm@selenic.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.