From: Josef Bacik <josef@toxicpanda.com>
To: Anand Jain <anand.jain@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 3/5] btrfs: remove identified alien btrfs device in open_fs_devices
Date: Thu, 16 Jan 2020 10:56:04 -0500 [thread overview]
Message-ID: <550c6454-be48-51bb-1196-40586e3649b7@toxicpanda.com> (raw)
In-Reply-To: <20191007094515.925-4-anand.jain@oracle.com>
On 10/7/19 5:45 AM, Anand Jain wrote:
> In open_fs_devices() we identify alien device but we don't reset its
> the device::name. So progs device list does not show the device missing
> as shown in the script below.
>
> mkfs.btrfs -fq /dev/sdd && mount /dev/sdd /btrfs
> mkfs.btrfs -fq -draid1 -mraid1 /dev/sdc /dev/sdb
> sleep 3 # avoid racing with udev's useless scans if needed
> btrfs dev add -f /dev/sdb /btrfs
> mount -o degraded /dev/sdc /btrfs1
>
> No missing device:
> btrfs fi show -m /btrfs1
> Label: none uuid: 3eb7cd50-4594-458f-9d68-c243cc49954d
> Total devices 2 FS bytes used 128.00KiB
> devid 1 size 12.00GiB used 1.26GiB path /dev/sdc
> devid 2 size 12.00GiB used 1.26GiB path /dev/sdb
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
Why not just remove the device if there's any error? I'm not sure why these
particular checks make a difference from any other error? Thanks,
Josef
next prev parent reply other threads:[~2020-01-16 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 9:45 [PATCH v3 0/5] btrfs: fix issues due to alien device Anand Jain
2019-10-07 9:45 ` [PATCH 1/5] btrfs: drop useless goto in open_fs_devices Anand Jain
2020-01-16 15:52 ` Josef Bacik
2019-10-07 9:45 ` [PATCH 2/5] btrfs: include non-missing as a qualifier for the latest_bdev Anand Jain
2020-01-16 15:52 ` Josef Bacik
2020-01-17 3:01 ` Anand Jain
2019-10-07 9:45 ` [PATCH v3 3/5] btrfs: remove identified alien btrfs device in open_fs_devices Anand Jain
2020-01-16 15:56 ` Josef Bacik [this message]
2020-01-17 9:10 ` Anand Jain
2020-01-17 14:23 ` Josef Bacik
2019-10-07 9:45 ` [PATCH 4/5] btrfs: remove identified alien " Anand Jain
2019-10-07 13:30 ` Nikolay Borisov
2019-10-07 13:37 ` Qu Wenruo
2019-10-07 17:03 ` David Sterba
2019-10-08 3:26 ` Anand Jain
2020-01-15 8:56 ` Anand Jain
2019-10-07 9:45 ` [PATCH 5/5] btrfs: free alien device due to device add Anand Jain
2020-01-16 16:00 ` Josef Bacik
2019-10-07 17:36 ` [PATCH v3 0/5] btrfs: fix issues due to alien device David Sterba
2019-10-08 6:11 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550c6454-be48-51bb-1196-40586e3649b7@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.