From: Eric Sandeen <sandeen@sandeen.net>
To: Wang Sheng-Hui <shhuiw@foxmail.com>,
fstests@vger.kernel.org, eguan@redhat.com
Subject: Re: [PATCH] xfstests: correct comment in generic/135
Date: Wed, 20 May 2015 20:06:49 -0500 [thread overview]
Message-ID: <555D2FA9.3060107@sandeen.net> (raw)
In-Reply-To: <1432168977-4330-1-git-send-email-shhuiw@foxmail.com>
On 5/20/15 7:42 PM, Wang Sheng-Hui wrote:
> xfs_io '-d' specifies direct IO, not sync IO.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
Ok, sure. :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> tests/generic/135 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/135 b/tests/generic/135
> index 79558f5..2444803 100755
> --- a/tests/generic/135
> +++ b/tests/generic/135
> @@ -63,7 +63,7 @@ $XFS_IO_PROG -f -c 'pwrite -b 4k -S 0x12 0 4k' async_file > /dev/null
> # create file with sync I/O
> $XFS_IO_PROG -f -s -c 'pwrite -b 4k -S 0x34 0 4k' sync_file > /dev/null
>
> -# create file with sync I/O
> +# create file with direct I/O
> $XFS_IO_PROG -f -d -c 'pwrite -b 4k -S 0x56 0 4k' direct_file > /dev/null
>
> # create file, truncate and then dirty again
>
prev parent reply other threads:[~2015-05-21 1:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 0:42 [PATCH] xfstests: correct comment in generic/135 Wang Sheng-Hui
2015-05-21 1:06 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555D2FA9.3060107@sandeen.net \
--to=sandeen@sandeen.net \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=shhuiw@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.