From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: David Lin <CTLIN0@nuvoton.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, WTLI@nuvoton.com,
SJLIN0@nuvoton.com, KCHSU0@nuvoton.com, lgirdwood@gmail.com,
YHCHuang@nuvoton.com, mac.chiang@intel.com
Subject: Re: [PATCH 1/3] ASoC: nau8825: add set_jack coponment support
Date: Tue, 26 Oct 2021 12:35:33 -0500 [thread overview]
Message-ID: <55937591-e1f1-9f1e-2355-e7680026f05d@linux.intel.com> (raw)
In-Reply-To: <20211026093828.4188145-2-CTLIN0@nuvoton.com>
On 10/26/21 4:38 AM, David Lin wrote:
> Use set_jack ops to set jack for new machine drivers. Meanwhile,
> the old machine drivers can still call previous export function
> "nau8825_enable_jack_detect".
>
> Co-Developed-by: Mac Chiang <mac.chiang@intel.com>
if you use the Co-developed-by: tag (no capital letter after 'C'), you
still need to provide your Signed-off-by: tag
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
same comment for the 2 other patches in this series.
> Signed-off-by: David Lin <CTLIN0@nuvoton.com>
> ---
> sound/soc/codecs/nau8825.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c
> index 67de0e49ccf4..c845f19b7c41 100644
> --- a/sound/soc/codecs/nau8825.c
> +++ b/sound/soc/codecs/nau8825.c
> @@ -2416,6 +2416,12 @@ static int __maybe_unused nau8825_resume(struct snd_soc_component *component)
> return 0;
> }
>
> +static int nau8825_set_jack(struct snd_soc_component *component,
> + struct snd_soc_jack *jack, void *data)
> +{
> + return nau8825_enable_jack_detect(component, jack);
> +}
> +
> static const struct snd_soc_component_driver nau8825_component_driver = {
> .probe = nau8825_component_probe,
> .remove = nau8825_component_remove,
> @@ -2430,6 +2436,7 @@ static const struct snd_soc_component_driver nau8825_component_driver = {
> .num_dapm_widgets = ARRAY_SIZE(nau8825_dapm_widgets),
> .dapm_routes = nau8825_dapm_routes,
> .num_dapm_routes = ARRAY_SIZE(nau8825_dapm_routes),
> + .set_jack = nau8825_set_jack,
> .suspend_bias_off = 1,
> .idle_bias_on = 1,
> .use_pmdown_time = 1,
>
next prev parent reply other threads:[~2021-10-26 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 9:38 [PATCH 0/3] Make genaral and simple for new sof machine driver David Lin
2021-10-26 9:38 ` [PATCH 1/3] ASoC: nau8825: add set_jack coponment support David Lin
2021-10-26 17:35 ` Pierre-Louis Bossart [this message]
2021-10-26 17:58 ` Mark Brown
2021-10-26 18:53 ` Pierre-Louis Bossart
2021-10-26 19:05 ` Mark Brown
2021-10-27 2:37 ` AS50 CTLin0
2021-10-26 9:38 ` [PATCH 2/3] ASoC: nau8825: add disable jack detection support David Lin
2021-10-26 9:38 ` [PATCH 3/3] ASoC: nau8825: add clock management for power saving David Lin
2021-10-27 17:29 ` [PATCH 0/3] Make genaral and simple for new sof machine driver Mark Brown
2021-10-27 2:51 David Lin
2021-10-27 2:51 ` [PATCH 1/3] ASoC: nau8825: add set_jack coponment support David Lin
2021-10-27 14:02 ` Pierre-Louis Bossart
2021-10-28 7:43 ` AS50 CTLin0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55937591-e1f1-9f1e-2355-e7680026f05d@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=SJLIN0@nuvoton.com \
--cc=WTLI@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mac.chiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.