From: Mark Zhang <markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v2 10/12] drm/tegra: Suspend dc/dsi/panel in one-shot mode
Date: Wed, 1 Jul 2015 17:03:17 +0800 [thread overview]
Message-ID: <5593ACD5.2090403@nvidia.com> (raw)
In-Reply-To: <20150701090005.GC24055-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
On 07/01/2015 05:00 PM, Daniel Vetter wrote:
> On Wed, Jul 01, 2015 at 04:21:53PM +0800, Mark Zhang wrote:
>> @@ -756,7 +752,11 @@ tegra_dsi_connector_duplicate_state(struct drm_connector *connector)
>> }
>>
>> static const struct drm_connector_funcs tegra_dsi_connector_funcs = {
>> - .dpms = tegra_dsi_connector_dpms,
>> + /*
>> + * drm_atomic_helper_connector_dpms only handles DPMS ON/OFF,
>> + * so use drm_helper_connector_dpms instead.
>> + */
>> + .dpms = drm_helper_connector_dpms,
>
> Nope, mixing legacy dpms handling into an atomic driver is a no-go. You
> need to use drm_atomic_helper_connector_dpms here.
yeah, so I have to change "drm_atomic_helper_connector_dpms"?
Mark
> -Daniel
>
next prev parent reply other threads:[~2015-07-01 9:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 8:21 [PATCH v2 00/12] Tegra: Add DC one-shot support Mark Zhang
[not found] ` <1435738915-31973-1-git-send-email-markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-07-01 8:21 ` [PATCH v2 01/12] drm: panel: Add a new private mode flag: DRM_PANEL_FLAG_PREFER_ONE_SHOT Mark Zhang
2015-07-01 8:54 ` Daniel Vetter
[not found] ` <20150701085437.GB24055-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2015-07-01 13:01 ` Mark Zhang
2015-07-01 8:21 ` [PATCH v2 02/12] drm: panel: Add one-shot flag to Sharp lq101r1sx01 driver Mark Zhang
2015-07-01 8:21 ` [PATCH v2 03/12] drm: panel: Turn on TE(Tearing Effect) on Sharp lq101r1sx01 Mark Zhang
2015-07-01 8:21 ` [PATCH v2 04/12] drm: panel: Add DRM panel private mode flag: TE polarity Mark Zhang
2015-07-01 8:21 ` [PATCH v2 05/12] drm: panel: Set TE polarity flag in Sharp lq101r1sx01 driver Mark Zhang
2015-07-01 8:21 ` [PATCH v2 06/12] drm/tegra: Set NC(Non-contiguous) mode to dc for one-shot Mark Zhang
2015-07-01 8:21 ` [PATCH v2 07/12] drm/panel: Add panel func: idle/busy Mark Zhang
2015-07-01 8:21 ` [PATCH v2 08/12] drm: dsi: Add "enter idle" & "exit idle" dcs functions Mark Zhang
2015-07-01 9:08 ` Varka Bhadram
[not found] ` <5593AE18.2070306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-07-01 9:17 ` Mark Zhang
2015-07-01 8:21 ` [PATCH v2 09/12] drm: panel: Add idle/busy in Sharp lq101r1sx01 driver Mark Zhang
2015-07-01 8:21 ` [PATCH v2 10/12] drm/tegra: Suspend dc/dsi/panel in one-shot mode Mark Zhang
[not found] ` <1435738915-31973-11-git-send-email-markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-07-01 9:00 ` Daniel Vetter
[not found] ` <20150701090005.GC24055-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2015-07-01 9:03 ` Mark Zhang [this message]
2015-07-01 8:21 ` [PATCH v2 11/12] drm/tegra: dsi: Set connector DPMS state when enable/disable Mark Zhang
2015-07-01 8:21 ` [PATCH v2 12/12] JUST FOR TEST: Add one-shot trigger to update display Mark Zhang
[not found] ` <1435738915-31973-13-git-send-email-markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-07-01 8:36 ` Daniel Vetter
[not found] ` <20150701083617.GF30960-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2015-07-01 8:46 ` Daniel Vetter
[not found] ` <20150701084511.GA24055-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2015-07-01 12:51 ` Mark Zhang
2015-07-01 9:01 ` Mark Zhang
[not found] ` <5593AC80.10801-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-07-01 10:34 ` Daniel Vetter
[not found] ` <20150701103457.GD24055-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2015-07-01 12:43 ` Mark Zhang
[not found] ` <5593E055.5050305-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-07-01 14:55 ` Daniel Vetter
[not found] ` <20150701145535.GW23343-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2015-07-03 7:57 ` Mark Zhang
[not found] ` <55964083.60001-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-07-03 8:03 ` Daniel Vetter
[not found] ` <20150703080328.GI23343-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2015-07-03 8:05 ` Mark Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5593ACD5.2090403@nvidia.com \
--to=markz-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=daniel-/w4YWyX8dFk@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.