From: Alim Akhtar <alim.akhtar@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
JBottomley@odin.com, vinholikatti@gmail.com,
amit.daniel@samsung.com, essuuj@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs
Date: Tue, 13 Oct 2015 17:15:39 +0530 [thread overview]
Message-ID: <561CEEE3.7060401@samsung.com> (raw)
In-Reply-To: <6499659.hVBcEphJIR@wuerfel>
On 10/13/2015 05:08 PM, Arnd Bergmann wrote:
> On Tuesday 13 October 2015 16:49:39 Alim Akhtar wrote:
>>>> diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h
>>>> new file mode 100644
>>>> index 0000000..58aa714
>>>> --- /dev/null
>>>> +++ b/drivers/scsi/ufs/ufs-exynos.h
>>>> @@ -0,0 +1,463 @@
>>>> +/*
>>>> + * UFS Host Controller driver for Exynos specific extensions
>>>> + *
>>>> + * Copyright (C) 2014-2015 Samsung Electronics Co., Ltd.
>>>> + *
>>>> + * This program is free software; you can redistribute it and/or modify
>>>> + * it under the terms of the GNU General Public License as published by
>>>> + * the Free Software Foundation; either version 2 of the License, or
>>>> + * (at your option) any later version.
>>>> + */
>>>> +
>>>> +#ifndef _UFS_EXYNOS_H_
>>>> +#define _UFS_EXYNOS_H_
>>>
>>> You have a lot of things in this header that are only used in one of the
>>> .c files, so just move them there and make the header as small as possible.
>>>
>> hmm..these are mostly the registers defines, will removes the one which
>> are not being used as of now.
>> Do you think I should sill move them to .c file?
>>
>
> Yes. No need to remove the unused register definitions, just don't put
> them into a separate header if they are only used in one place.
>
Ok will do that in v4.
Thanks.
> Arnd
>
next prev parent reply other threads:[~2015-10-13 11:55 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 8:09 [PATCH v3 00/13] exynos-ufs: add support for Exynos Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 01/13] Documentation: samsung-phy: Add dt bindings for UFS Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 02/13] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC Alim Akhtar
2015-10-01 8:41 ` kbuild test robot
2015-10-01 8:41 ` kbuild test robot
2015-10-01 8:41 ` [PATCH] phy: exynos-ufs: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-10-01 11:04 ` [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static kbuild test robot
2015-10-13 11:38 ` Alim Akhtar
2015-10-13 12:58 ` [kbuild-all] " Fengguang Wu
2015-10-13 12:58 ` Fengguang Wu
2015-10-13 14:02 ` Kishon Vijay Abraham I
2015-10-13 14:02 ` Kishon Vijay Abraham I
2015-10-01 11:04 ` [PATCH v3 02/13] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC kbuild test robot
2015-10-01 8:09 ` [PATCH v3 03/13] scsi: ufs: add quirk to contain unconformable utrd field Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 04/13] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 05/13] scsi: ufs: add quirk not to allow reset of interrupt aggregation Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 06/13] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 07/13] scsi: ufs: add specific callback for nexus type Alim Akhtar
2015-10-01 8:09 ` Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 08/13] scsi: ufs: add add specific callback for hibern8 Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 09/13] scsi: ufs: make ufshcd_config_pwr_mode of non-static func Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 10/13] scsi: ufs: return value of pwr_change_notify Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller Alim Akhtar
2015-10-01 11:37 ` Arnd Bergmann
2015-10-13 11:36 ` Alim Akhtar
2015-10-13 12:10 ` Arnd Bergmann
2015-10-01 8:09 ` [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
2015-10-01 12:12 ` Arnd Bergmann
2015-10-01 12:12 ` Arnd Bergmann
2015-10-13 11:19 ` Alim Akhtar
2015-10-13 11:38 ` Arnd Bergmann
2015-10-13 11:38 ` Arnd Bergmann
2015-10-13 11:45 ` Alim Akhtar [this message]
2015-10-01 8:09 ` [PATCH v3 13/13] scsi: ufs: Add exynos ufs platform data Alim Akhtar
2015-10-01 10:04 ` kbuild test robot
2015-10-01 10:14 ` kbuild test robot
2015-10-01 10:14 ` kbuild test robot
2015-10-01 10:46 ` kbuild test robot
2015-10-01 11:29 ` Arnd Bergmann
2015-10-01 11:29 ` Arnd Bergmann
2015-10-05 8:14 ` Alim Akhtar
2015-10-05 9:06 ` Arnd Bergmann
2015-10-05 14:11 ` Rob Herring
2015-10-05 14:47 ` Arnd Bergmann
2015-10-05 14:47 ` Arnd Bergmann
2015-10-05 15:20 ` Alim Akhtar
2015-10-05 15:20 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561CEEE3.7060401@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=JBottomley@odin.com \
--cc=amit.daniel@samsung.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=essuuj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.