Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

From: Michal Marek <mmarek@suse.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: rds-devel@oss.oracle.com, linux-ia64@vger.kernel.org,
	linux-kbuild@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros
Date: Wed, 21 Oct 2015 21:52:45 +0200	[thread overview]
Message-ID: <5627ED0D.20308__20002.5531849407$1445457279$gmane$org@suse.com> (raw)
In-Reply-To: <5627E73B.9000502@redhat.com>

Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a):
> On 10/15/2015 04:16 PM, Michal Marek wrote:
>> Otherwise make tags can't parse them:
>>
>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1"
>> ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name pattern "\1"
>> ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name pattern "\1"
>> ctags: Warning: kernel/locking/lockdep.c:153: null expansion of name pattern "\1"
>> ctags: Warning: kernel/workqueue.c:305: null expansion of name pattern "\1"
>> ctags: Warning: kernel/rcu/rcutorture.c:133: null expansion of name pattern "\1"
>> ctags: Warning: kernel/rcu/rcutorture.c:135: null expansion of name pattern "\1"
>> ctags: Warning: net/rds/page.c:45: null expansion of name pattern "\1"
>> ctags: Warning: net/ipv4/syncookies.c:53: null expansion of name pattern "\1"
>> ctags: Warning: net/ipv6/syncookies.c:44: null expansion of name pattern "\1"
> 
> I guarantee you're going to end up fixing this issue over and over again as more
> code is added in.

This is certainly going to happen, but it should be quickly spotted by
anybody running make tags on linux-next. And 10 instances since the
beginning of git is not too many.

> OOC, why not fix ctags to recognize newlines?

It's not ctags itself parsing the DEFINE_PER_CPU() macro, but a
user-supplied regex specified on commandline. Which can only operate on
single lines.

Michal