Re: [PATCH RFC v2 0/2] Disable planes on blanked CRTC and enable on unblank

From: Jyri Sarha <jsarha@ti.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org,
	laurent.pinchart@ideasonboard.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RFC v2 0/2] Disable planes on blanked CRTC and enable on unblank
Date: Tue, 17 Nov 2015 17:38:35 +0200	[thread overview]
Message-ID: <564B49FB.8020306@ti.com> (raw)
In-Reply-To: <20151117102856.GS16848@phenom.ffwll.local>

On 11/17/15 12:28, Daniel Vetter wrote:
> On Fri, Nov 13, 2015 at 05:53:13PM +0200, Jyri Sarha wrote:
>> Since first RFC version:
>> - Added "drm/atomic: Track drm_plane's active state"-patch
>>
>> We would need something like this to get rid off OMAPDSS somewhat
>> messy runtime_resume code. How does this look, could this generic
>> solution be refined to be acceptable for mainline, or should we start
>> looking a local solution to omapdrm?
>
> One more comment besides what I've written in the older thread: You're not
> on latest drm-next, which has gained an active_only paramter to the plane
> commit helper.
>
> It might be best to discuss this topic on #dri-devel on freenode irc a
> bit.
>

Thanks a lot for you comments!

I just rebased my stuff on top the the latest drm-next. I think I need 
digest your earlier comments about drm_atomic_add_affected_planes etc. a 
bit before I can take advantage of any interactive communication. I'll 
try to follow those instruction first and see where it leads me.

Thanks,
Jyri

> Cheers, Daniel
>
>>
>> Jyri Sarha (2):
>>    drm/atomic: Track drm_plane's active state
>>    drm/atomic: Disable planes on blanked CRTC and enable on unblank
>>
>>   drivers/gpu/drm/drm_atomic_helper.c | 82 +++++++++++++++++++++++++++++--------
>>   drivers/gpu/drm/drm_plane_helper.c  | 10 +----
>>   include/drm/drm_atomic_helper.h     | 39 +-----------------
>>   include/drm/drm_crtc.h              |  2 +
>>   4 files changed, 70 insertions(+), 63 deletions(-)
>>
>> --
>> 1.9.1
>>
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel