Re: [PATCH -next] integrity: Make function integrity_add_key() static

From: Nayna <nayna@linux.vnet.ibm.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: linux-security-module@vger.kernel.org,
	Scott Branden <scott.branden@broadcom.com>,
	Hulk Robot <hulkci@huawei.com>, James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mimi Zohar <zohar@linux.ibm.com>,
	Kees Cook <keescook@chromium.org>,
	Tushar Sugandhi <tusharsu@linux.microsoft.com>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH -next] integrity: Make function integrity_add_key() static
Date: Fri, 12 Feb 2021 11:11:01 -0500	[thread overview]
Message-ID: <565ffe94-a453-31b4-8b7d-9e03d406e10d@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210210080131.1209889-1-weiyongjun1@huawei.com>


On 2/10/21 3:01 AM, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> security/integrity/digsig.c:146:12: warning:
>   symbol 'integrity_add_key' was not declared. Should it be static?
>
> This function is not used outside of digsig.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>   security/integrity/digsig.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> index 0f518dcfde05..250fb0836156 100644
> --- a/security/integrity/digsig.c
> +++ b/security/integrity/digsig.c
> @@ -143,8 +143,8 @@ int __init integrity_init_keyring(const unsigned int id)
>   	return __integrity_init_keyring(id, perm, restriction);
>   }
>
> -int __init integrity_add_key(const unsigned int id, const void *data,
> -			     off_t size, key_perm_t perm)
> +static int __init integrity_add_key(const unsigned int id, const void *data,
> +				    off_t size, key_perm_t perm)
>   {
>   	key_ref_t key;
>   	int rc = 0;

Reviewed-by: Nayna Jain <nayna@linux.ibm.com>


Thanks & Regards,
     - Nayna