Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel

From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Inki Dae <daeinki@gmail.com>
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel
Date: Mon, 7 Dec 2015 09:17:16 -0300	[thread overview]
Message-ID: <566578CC.2040304@osg.samsung.com> (raw)
In-Reply-To: <CAAQKjZP5oK3o6LLbTb2UERXw+x0E=ZjWB+E-yUrthHd3VzTd2g@mail.gmail.com>

[adding Krzysztof and Kukjin to cc list]

Hello Inki,

On 12/06/2015 01:25 PM, Inki Dae wrote:
> Hi Javier,
> 
> 2015-12-03 22:05 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>:
>>
>> Hello Inki,
>>
>> On 12/02/2015 11:11 PM, Inki Dae wrote:
>>> Hi Javier,
>>>
>>> 2015년 12월 03일 00:04에 Javier Martinez Canillas 이(가) 쓴 글:
>>>> Hello Inki,
>>>>
>>>> On 12/02/2015 08:57 AM, Inki Dae wrote:
>>>>> This patch adds of_graph dt binding support for panel device
>>>>> and also keeps the backward compatibility.
>>>>>
>>>>
>>>> You have to also update the DT binding doc which seems to be
>>>> outdated already:
>>>>
>>>> Documentation/devicetree/bindings/display/exynos/exynos_dp.txt
>>>
>>> Right. It should be updated.
>>>
>>
>> Great, I see you already posted that.
>>
>>>>
>>>>> i.e.,
>>>>> The dts file for Exynos5800 based peach pi board
>>>>> has a panel property so we need to keep the backward compatibility.
>>>>>
>>>>
>>>> How did you test this patch?
>>>
>>> I thought you will test it and give me tested-by because you commented like below,
>>> " Assuming you can make a distinction if the endpoint is a panel or a bridge,
>>> then yes, I agree with the idea of the patch. Please feel free to cc me if
>>> you post such a patch and I'll gladly test it on my Exynos5800 Peach Pi."
>>>
>>> That is why I cced you. I really have no any Exynos5800 Peach Pi board.
>>>
>>
>> Yes, but if you didn't test a patch, then it should be marked with a RFT
>> prefix in the subject line or at least mention that needs testing since
>> you lack the HW to test. I've no way to know if you have another board
>> with a similar design :)
>>
>> But what I meant is how the patch is supposed to be tested since there
>> ins't a change in the Exynos5800 Peach Pi DTS? We can of course test
>> that doesn't break backward compatibility but we don't have a way to
>> test the actual change.
>>
>> So I tested with the patch following patch [0] and things are working
>> correctly. Please include that patch in your series.
> 
> Will pick it up. And  I commented on below your patch.
>

Ok, you need an ack from Krzysztof / Kukjin before picking the patch
though and cc them if you are planning to repost the whole series.

Another option is to wait until your Exynos DRM patches hit mainline
and then the DTS change can be posted separately.

>>
>> I've some comments on your patch though but I'll comment on your lastest
>> version.
>>
>>> Thanks,
>>> Inki Dae
>>>
>>>>
>>>> Best regards,
>>>>
>>
>> Best regards,
>> --
>> Javier Martinez Canillas
>> Open Source Group
>> Samsung Research America
>>
>> [0]:
>> From 644bab7949ac17a8d42ca0cf36cd55d61bc88928 Mon Sep 17 00:00:00 2001
>> From: Javier Martinez Canillas <javier@osg.samsung.com>
>> Date: Thu, 3 Dec 2015 09:32:17 -0300
>> Subject: [PATCH 1/1] ARM: dts: Use OF graph for DP to panel connection in
>>  exynos5800-peach-pi
>>
>> The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent
>> since it uses a phandle to describe the connection between the DP port and
>> the display panel but uses the OF graph ports and endpoints to describe the
>> connection betwen the DP port, a bridge chip and the panel.
>>
>> The Exynos DP driver and the DT binding have been changed to allow also to
>> describe the DP port to panel connection using ports / endpoints (OF graph)
>> so this patch changes the Exynos5800 Peach Pi DT to make it consistent with
>> the Exynos5420 Peach Pit that has a eDP to LVDS chip and uses OF graph too.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5800-peach-pi.dts | 15 ++++++++++++++-
>>  1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index 7b018e451880..9c6fd7314ee0 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -122,6 +122,12 @@
>>                 compatible = "auo,b133htn01";
>>                 power-supply = <&tps65090_fet6>;
>>                 backlight = <&backlight>;
>> +
>> +               port {
>> +                       panel_in: endpoint {
>> +                               remote-endpoint = <&dp_out>;
>> +                       };
>> +               };
>>         };
>>
>>         mmc1_pwrseq: mmc1_pwrseq {
>> @@ -148,7 +154,14 @@
>>         samsung,link-rate = <0x0a>;
>>         samsung,lane-count = <2>;
>>         samsung,hpd-gpio = <&gpx2 6 GPIO_ACTIVE_HIGH>;
>> -       panel = <&panel>;
>> +
>> +       ports {
>> +               port@0 {
> 
> As Rob commented before, I will pick it up removing @0 if you are ok.
>

Ok, it is true that there isn't an #address-cells, #size-cells and reg
properties since there is a single port so I guess the @0 is arbitrary
here so it doesn't represent a proper unit-address and can be removed.

> Thanks,
> Inki Dae
> 
>> +                       dp_out: endpoint {
>> +                               remote-endpoint = <&panel_in>;
>> +                       };
>> +               };
>> +       };
>>  };
>>
>>  &fimd {
>> --
>> 2.4.3
>>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America