Re: [PATCH] build: save generated config in /boot

From: Doug Goldstein <cardoe@cardoe.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] build: save generated config in /boot
Date: Mon, 21 Dec 2015 09:20:19 -0600	[thread overview]
Message-ID: <567818B3.6060908@cardoe.com> (raw)
In-Reply-To: <56781FFA02000078000C1F3D@prv-mh.provo.novell.com>

[-- Attachment #1.1: Type: text/plain, Size: 2111 bytes --]

On 12/21/15 8:51 AM, Jan Beulich wrote:
>>>> On 21.12.15 at 15:35, <cardoe@cardoe.com> wrote:
>> On 12/21/15 6:11 AM, Jan Beulich wrote:
>>>>>> On 18.12.15 at 22:35, <cardoe@cardoe.com> wrote:
>>>> Since we now support changing Xen options with Kconfig, we should save
>>>> the configuration that was used to build up Xen. This will save it in
>>>> /boot alongside the installed xen.gz and call it
>>>> xen-$(FULLVERSION).config
>>>>
>>>> Suggested-by: Ian Campbell <ian.campbell@citrix.com>
>>>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>>>> ---
>>>>  xen/Makefile | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/xen/Makefile b/xen/Makefile
>>>> index 9023863..460b977 100644
>>>> --- a/xen/Makefile
>>>> +++ b/xen/Makefile
>>>> @@ -58,6 +58,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
>>>>  	ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z)
>>>>  	[ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR)
>>>>  	$(INSTALL_DATA) $(TARGET)-syms $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FULLVERSION)
>>>> +	$(INSTALL_DATA) $(KCONFIG_CONFIG) 
>> $(D)$(BOOT_DIR)/$(T)-$(XEN_FULLVERSION).config
>>>
>>> Was it really suggested to put this into /boot? It has no business
>>> being there...
>>
>> Yes. By multiple people. Ian Campbell was the first person to suggest it
>> in that location.
> 
> Okay, so I've looked it up, and no, he didn't. He just gave this as one
> possibility:
> 
> "It occurred to me this morning that we probably ought to stash the .config
>  somewhere on install in such a way that it can be associated with the Xen
>  binary (i.e. with the same full suffix as the binary itself, not the
>  abridged symlink names), maybe as $(BOOT_DIR)/$(T)-
>  $(XEN_FULLVERSION).config?"
> 
> But yes, I'm sorry for not noticing this as an undesirable place right
> away.
> 
> Jan
> 
> 

Ok well I'm at a loss here because the quote clearly shows him
suggesting that location. Do you have a suggested location because so
far I've just got a no from you on the only suggested location.

-- 
Doug Goldstein

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel