Re: [cip-dev][isar-cip-core][PATCH v3 0/6] Make swupdate signing more robust

From: Gylstorff Quirin <quirin.gylstorff@siemens.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	cip-dev@lists.cip-project.org, felix.moessbauer@siemens.com
Subject: Re: [cip-dev][isar-cip-core][PATCH v3 0/6] Make swupdate signing more robust
Date: Wed, 13 Mar 2024 08:57:16 +0100	[thread overview]
Message-ID: <56791b55-c6ba-4fb8-84e1-ad2ceead8345@siemens.com> (raw)
In-Reply-To: <487f769c-d9c1-4071-ba45-71563eb0a411@siemens.com>

On 3/12/24 8:21 PM, Jan Kiszka wrote:
> On 12.03.24 19:50, Gylstorff Quirin wrote:
>>
>>
>> On 3/12/24 7:12 PM, Quirin Gylstorff via lists.cip-project.org wrote:
>>>
>>>
>>> On 3/12/24 9:40 AM, Jan Kiszka wrote:
>>>> On 05.03.24 17:10, Quirin Gylstorff wrote:
>>>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>>>
>>>>> This patchset adds checks to validate the certificate and key before
>>>>> used in the signing process.
>>>>>
>>>>> Add also adds the missing Documentation about swu signing in cip-core
>>>>> and fixes two issues:
>>>>>    - an error in the build logs of do_image_swu
>>>>>    - Creating all existing image recipes by touching SRC_URI in a anonym
>>>>>      python function.
>>>>>
>>>>> Changes v3:
>>>>>    - rebase onto next(704353612238cb2ac1c16f29db6f314b60cd83b0)
>>>>>    - use local variable to increase readability
>>>>>    - add formatting patches
>>>>>    - fix typo in commit message
>>>>>
>>>>> Changes v2:
>>>>>     - Add information about cpio option in long form
>>>>>     - replace cpio option `-H` with long form '--format='
>>>>>
>>>>>
>>>>> Quirin Gylstorff (6):
>>>>>     swupdate: check output of sign-swu
>>>>>     sign-swu-cms: check if key and cert are valid
>>>>>     doc: Add section about SWUpdate signing to README.swupdate.md
>>>>>     fix do not add files to each image recipe
>>>>>     format: classes/efibootguard fix spacing
>>>>>     format: classes/swupdate fix parenthesis
>>>>>
>>>>>    classes/efibootguard.bbclass                  | 39 ++++----
>>>>>    classes/swupdate.bbclass                      | 88
>>>>> +++++++++++++------
>>>>>    doc/README.swupdate.md                        | 21 +++++
>>>>>    .../swupdate-certificates/files/sign-swu-cms  | 29 +++++-
>>>>>    4 files changed, 127 insertions(+), 50 deletions(-)
>>>>>
>>>>
>>>> Thanks, applied.
>>> There is a regression on next which was not there on my integration
>>> branch. Can you please revert.
>>
>> @Jan You removed a `\` in line
>> https://gitlab.com/cip-project/cip-core/isar-cip-core/-/blob/next/classes/swupdate.bbclass?ref_type=heads#L232 with
>> https://gitlab.com/cip-project/cip-core/isar-cip-core/-/commit/8d9e44a154ee685dc2311b7248d5f269350d2fd6
> 
> Oops, sorry, fixed now.
 >
 > Jan
 >

Ok that was the issue - the swu now contains all files again.

Thanks
Quirin