From: Joe Perches <joe@perches.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Denis Efremov <efremov@linux.com>,
"David S. Miller" <davem@davemloft.net>,
Song Liu <song@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH 17/19] z2ram: reindent
Date: Thu, 27 Aug 2020 17:01:50 -0700 [thread overview]
Message-ID: <5682daf68b94be288c05f859942ce06deec2b022.camel@perches.com> (raw)
In-Reply-To: <alpine.LNX.2.23.453.2008280859300.10@nippy.intranet>
On Fri, 2020-08-28 at 09:21 +1000, Finn Thain wrote:
> > @@ -109,34 +111,28 @@ static void get_z2ram(void)
> ...
> > }
> > -
> > - return;
> > }
> >
>
> It would be good to have a semantic patch for that change.
>
> >
> > - if (z2ram_map[z2ram_size] == 0) {
> > + if (z2ram_map[z2ram_size] == 0)
> > break;
> > - }
> >
>
> And that one.
>
> Reason being, a semantic patch only has to be debugged once, whereas
> manual churn has to be done correctly over and over again.
checkpatch already does this.
next prev parent reply other threads:[~2020-08-28 0:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 6:24 simplify gendisk lookup and remove struct block_device aliases Christoph Hellwig
2020-08-26 6:24 ` [PATCH 01/19] char_dev: replace cdev_map with an xarray Christoph Hellwig
2020-08-26 8:19 ` Greg Kroah-Hartman
2020-08-27 8:53 ` Christoph Hellwig
2020-08-27 9:18 ` Greg Kroah-Hartman
2020-08-27 9:39 ` Christoph Hellwig
2020-08-27 7:25 ` Hannes Reinecke
2020-08-27 8:55 ` Christoph Hellwig
2020-08-26 6:24 ` [PATCH 02/19] block: merge drivers/base/map.c into block/genhd.c Christoph Hellwig
2020-08-26 8:19 ` Greg Kroah-Hartman
2020-08-26 6:24 ` [PATCH 03/19] block: cleanup del_gendisk a bit Christoph Hellwig
2020-08-26 6:24 ` [PATCH 04/19] block: split block_class_lock Christoph Hellwig
2020-08-26 6:24 ` [PATCH 05/19] block: rework requesting modules for unclaimed devices Christoph Hellwig
2020-08-26 6:24 ` [PATCH 06/19] block: add an optional probe callback to major_names Christoph Hellwig
2020-08-26 6:24 ` [PATCH 07/19] ide: remove ide_{,un}register_region Christoph Hellwig
2020-08-27 7:25 ` Hannes Reinecke
2020-08-26 6:24 ` [PATCH 08/19] swim: don't call blk_register_region Christoph Hellwig
2020-08-26 6:24 ` [PATCH 09/19] sd: use __register_blkdev to avoid a modprobe for an unregistered dev_t Christoph Hellwig
2020-08-26 6:24 ` [PATCH 10/19] brd: use __register_blkdev to allocate devices on demand Christoph Hellwig
2020-08-26 6:24 ` [PATCH 11/19] loop: " Christoph Hellwig
2020-08-26 6:24 ` [PATCH 12/19] md: " Christoph Hellwig
2020-08-28 7:08 ` Song Liu
2020-08-26 6:24 ` [PATCH 13/19] ide: switch to __register_blkdev for command set probing Christoph Hellwig
2020-08-26 6:24 ` [PATCH 14/19] floppy: use a separate gendisk for each media format Christoph Hellwig
2020-08-26 6:24 ` [PATCH 15/19] amiflop: use separate gendisks for Amiga vs MS-DOS mode Christoph Hellwig
2020-08-26 6:24 ` [PATCH 16/19] ataflop: use a separate gendisk for each media format Christoph Hellwig
2020-08-26 6:24 ` [PATCH 17/19] z2ram: reindent Christoph Hellwig
2020-08-26 9:12 ` Joe Perches
2020-08-26 9:49 ` John Paul Adrian Glaubitz
2020-08-26 14:51 ` Joe Perches
2020-08-27 23:21 ` Finn Thain
2020-08-28 0:01 ` Joe Perches [this message]
2020-08-28 0:57 ` Finn Thain
2020-08-28 1:11 ` Joe Perches
2020-08-28 4:25 ` Christoph Hellwig
2020-08-26 6:24 ` [PATCH 18/19] z2ram: use separate gendisk for the different modes Christoph Hellwig
2020-08-26 6:24 ` [PATCH 19/19] block: switch gendisk lookup to a simple xarray Christoph Hellwig
2020-08-30 6:24 simplify gendisk lookup and remove struct block_device aliases v2 Christoph Hellwig
2020-08-30 6:24 ` [PATCH 17/19] z2ram: reindent Christoph Hellwig
2020-09-03 8:01 simplify gendisk lookup and remove struct block_device aliases v3 Christoph Hellwig
2020-09-03 8:01 ` [PATCH 17/19] z2ram: reindent Christoph Hellwig
2020-09-04 10:29 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5682daf68b94be288c05f859942ce06deec2b022.camel@perches.com \
--to=joe@perches.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=efremov@linux.com \
--cc=fthain@telegraphics.com.au \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.