From: Juergen Gross <jgross@suse.com>
To: Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com,
dgdegra@tycho.nsa.gov
Subject: Re: [PATCH v2 04/13] xenstore: move init-xenstore-domain to tools/helpers
Date: Thu, 7 Jan 2016 07:12:09 +0100 [thread overview]
Message-ID: <568E01B9.6070706@suse.com> (raw)
In-Reply-To: <1452096208.21055.102.camel@citrix.com>
On 06/01/16 17:03, Ian Campbell wrote:
> On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote:
>> The program init-xenstore-domain to start a xenstore domain instead
>> of the xenstored daemon is built, but not installed. Change that.
>>
>> Move the program to a new tools subdirectory "helpers" to be able to
>> use libxl in a later patch. Otherwise a dependency loop will be
>> created.
>>
>> While moving modify the coding style to the standard style used in
>> the tools directory.
>
> Please don't combine such things with moving the whole file. Or at the very
> least please use git send-email/format-patch -M (ideally both do it
> separately and use -M).
Okay, I'll do the move in this patch only.
> So long as the file is self consistent I'm not convinced it is actually
> worth changing, plus it doesn't actually seem to be following CODING_STYLE
> (which is the default style for tools/* as well as xen/*), since hasn't
> gained e.g. spaces inside of the if ( x ).
As there are substantial changes to this file in later patches, I'll do
the coding style changes in a separate patch, using the _correct_ style.
Juergen
next prev parent reply other threads:[~2016-01-07 6:12 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 13:14 [PATCH v2 00/13] xenstore: make it easier to run xenstore in a domain Juergen Gross
2015-12-18 13:14 ` [PATCH v2 01/13] xen: add xenstore domain flag to hypervisor Juergen Gross
2015-12-18 13:23 ` Andrew Cooper
2016-01-05 15:46 ` Ian Campbell
2016-01-05 15:59 ` Juergen Gross
2015-12-18 13:14 ` [PATCH v2 02/13] libxc: support new xenstore domain flag in libxc Juergen Gross
2016-01-06 15:52 ` Ian Campbell
2016-01-07 6:08 ` Juergen Gross
2016-01-07 10:12 ` Ian Campbell
2015-12-18 13:14 ` [PATCH v2 03/13] libxl: provide a function to retrieve the xenstore domain id Juergen Gross
2015-12-18 13:53 ` Andrew Cooper
2015-12-18 14:10 ` Juergen Gross
2016-01-06 15:59 ` Ian Campbell
2016-01-06 16:38 ` Ian Jackson
2016-01-07 5:37 ` Juergen Gross
2016-01-07 10:11 ` Ian Campbell
2016-01-07 10:44 ` Juergen Gross
2016-01-07 10:55 ` Ian Campbell
2016-01-07 11:21 ` Juergen Gross
2016-01-07 11:36 ` Ian Campbell
2016-01-07 13:17 ` Wei Liu
2016-01-07 12:40 ` Wei Liu
2016-01-07 12:57 ` Juergen Gross
2016-01-07 13:13 ` Wei Liu
2015-12-18 13:14 ` [PATCH v2 04/13] xenstore: move init-xenstore-domain to tools/helpers Juergen Gross
2016-01-06 16:03 ` Ian Campbell
2016-01-07 6:12 ` Juergen Gross [this message]
2015-12-18 13:14 ` [PATCH v2 05/13] libxl: move xen-init-dom0 " Juergen Gross
2016-01-06 16:12 ` Ian Campbell
2016-01-07 6:15 ` Juergen Gross
2016-01-07 10:12 ` Ian Campbell
2016-01-06 16:28 ` Ian Campbell
2016-01-07 6:39 ` Juergen Gross
2015-12-18 13:14 ` [PATCH v2 06/13] xenstore: destroy xenstore domain in case of error after creating it Juergen Gross
2015-12-18 13:14 ` [PATCH v2 07/13] xenstore: add error messages to init-xenstore-domain Juergen Gross
2015-12-18 13:14 ` [PATCH v2 08/13] xenstore: modify init-xenstore-domain parameter syntax Juergen Gross
2016-01-06 16:21 ` Ian Campbell
2016-01-07 6:34 ` Juergen Gross
2016-01-07 10:23 ` Ian Campbell
2016-01-07 10:28 ` Juergen Gross
2015-12-18 13:14 ` [PATCH v2 09/13] xenstore: make use of the "xenstore domain" flag Juergen Gross
2016-01-06 16:23 ` Ian Campbell
2016-01-07 6:36 ` Juergen Gross
2015-12-18 13:14 ` [PATCH v2 10/13] xenstore: add init-xenstore-domain parameter to specify cmdline Juergen Gross
2015-12-18 13:14 ` [PATCH v2 11/13] tools: split up xen-init-dom0.c Juergen Gross
2016-01-06 16:26 ` Ian Campbell
2016-01-06 16:33 ` Wei Liu
2016-01-07 10:26 ` Ian Campbell
2015-12-18 13:14 ` [PATCH v2 12/13] xenstore: write xenstore domain data to xenstore Juergen Gross
2016-01-06 16:27 ` Ian Campbell
2015-12-18 13:14 ` [PATCH v2 13/13] tools: don't stop xenstore domain when stopping dom0 Juergen Gross
2015-12-18 14:42 ` Andrew Cooper
2015-12-18 14:53 ` Juergen Gross
2016-01-06 16:33 ` Ian Campbell
2016-01-07 6:52 ` Juergen Gross
2016-01-07 10:34 ` Ian Campbell
2016-01-07 10:45 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568E01B9.6070706@suse.com \
--to=jgross@suse.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.