From: Malcolm Crossley <malcolm.crossley@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>,
JBeulich@suse.com, andrew.cooper3@citrix.com,
Marcos.Matsunaga@oracle.com, keir@xen.org,
konrad.wilk@oracle.com, george.dunlap@eu.citrix.com
Cc: xen-devel@lists.xenproject.org, dario.faggioli@citrix.com,
stefano.stabellini@citrix.com
Subject: Re: [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure
Date: Fri, 22 Jan 2016 14:30:32 +0000 [thread overview]
Message-ID: <56A23D08.9000608@citrix.com> (raw)
In-Reply-To: <1453472569.4320.94.camel@citrix.com>
On 22/01/16 14:22, Ian Campbell wrote:
> On Fri, 2016-01-22 at 14:16 +0000, Malcolm Crossley wrote:
>> On 22/01/16 13:54, Ian Campbell wrote:
>>> On Fri, 2016-01-22 at 13:41 +0000, Malcolm Crossley wrote:
>>>>
>>>> Changes since v5:
>>>> - Fix compilation on ARM
>>>
>>> This was the removal of some spurious "&", I think?
>>
>> Yeah, I forgot to keep the macro's in sync. ARM also needed the
>> xen/percpu.h header file to be
>> explictly included into spinlock.h.
>>
>>>
>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>
>>> Thanks for catching this!
>>
>> Sorry for not build testing before on ARM.
>
> No problem, some people never remember at all, so v5 isn't too bad ;-)
>
>> Building the hypervisor itself using a prebuilt linaro
>> toolchain is actually very easy (no chroot required).
>
> Indeed.
>
>> Do you think it's worth documenting this? So that at least hypervisor
>> build failures are caught.
>
> I think it's covered by
> http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions#Cross_Compiling
Yeah that section covers it. I came across the toolstack page first and didn't check the third link
down in google :)
https://www.google.co.uk/search?q=xen+cross+compilation
Maybe there should be comment in the toolstack page linking back to the simpler hypervisor only steps :)
>
> or do you mean something more?
>
> Ian.
>
next prev parent reply other threads:[~2016-01-22 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 13:41 [PATCHv6 0/3] Implement per-cpu reader-writer locks Malcolm Crossley
2016-01-22 13:41 ` [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure Malcolm Crossley
2016-01-22 13:54 ` Ian Campbell
2016-01-22 14:16 ` Malcolm Crossley
2016-01-22 14:22 ` Ian Campbell
2016-01-22 14:30 ` Malcolm Crossley [this message]
2016-01-22 14:45 ` Ian Campbell
2016-01-22 14:25 ` Ross Lagerwall
2016-01-22 13:41 ` [PATCHv6 2/3] grant_table: convert grant table rwlock to percpu rwlock Malcolm Crossley
2016-01-22 15:15 ` Jan Beulich
2016-01-22 15:22 ` Ian Campbell
2016-01-22 15:34 ` Jan Beulich
2016-01-22 15:53 ` Ian Campbell
2016-01-22 13:41 ` [PATCHv6 3/3] p2m: convert p2m " Malcolm Crossley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A23D08.9000608@citrix.com \
--to=malcolm.crossley@citrix.com \
--cc=JBeulich@suse.com \
--cc=Marcos.Matsunaga@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.