All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: user-mode-linux-devel@lists.sourceforge.net,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs
Date: Tue, 26 Jan 2016 09:17:55 +0100	[thread overview]
Message-ID: <56A72BB3.9090206@nod.at> (raw)
In-Reply-To: <1453767342.17181.26.camel@tiscali.nl>

Am 26.01.2016 um 01:15 schrieb Paul Bolle:
> On ma, 2016-01-25 at 23:24 +0100, Richard Weinberger wrote:
>> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
>> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig
> 
>>  config INV_MPU6050_IIO
>>  	tristate "Invensense MPU6050 devices"
>>  	depends on I2C && SYSFS
>> +	depends on I2C_MUX
> 
> Nit: if I parsed the v4.5-rc1 tree correctly I2C_MUX depends I2C. So
> just
> 	depends on I2C_MUX && SYSFS
> 
> should also do the trick. Is it clearer to mention both I2C and I2C_MUX
> explicitly?

I don't have a strong opinion on that. In general I'm a fan of explicit
dependencies but in this case, you are right, also an implicit one should to it.
Let's see what maintainers think. :-)

Thanks,
//richard

  reply	other threads:[~2016-01-26  8:18 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 22:23 Richard Weinberger
2016-01-25 22:23 ` [uml-devel] (no subject) Richard Weinberger
2016-01-25 22:24 ` [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 23:34   ` Florian Fainelli
2016-01-27  8:02     ` Richard Weinberger
2016-02-15  5:57   ` Sebastian Reichel
2016-01-25 22:24 ` [PATCH 02/22] phy: " Richard Weinberger
2016-02-03  6:21   ` Kishon Vijay Abraham I
2016-02-03  6:21     ` Kishon Vijay Abraham I
2016-01-25 22:24 ` [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs Richard Weinberger
2016-01-25 22:24   ` [uml-devel] " Richard Weinberger
2016-01-25 22:24   ` Richard Weinberger
2016-01-26 10:15   ` John Garry
2016-01-26 10:15     ` John Garry
2016-01-26 10:31     ` Richard Weinberger
2016-01-26 10:54       ` John Garry
2016-01-26 10:54         ` John Garry
2016-01-27  2:16         ` Martin K. Petersen
2016-01-27  2:16           ` Martin K. Petersen
2016-01-25 22:24 ` [PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 10:59   ` Geert Uytterhoeven
2016-01-30 15:47     ` Jonathan Cameron
2016-01-25 22:24 ` [PATCH 05/22] hw_random: " Richard Weinberger
2016-01-26  9:58   ` Daniel Thompson
2016-01-26 14:49   ` Herbert Xu
2016-01-25 22:24 ` [PATCH 06/22] iio: adc: " Richard Weinberger
2016-01-30 15:44   ` Jonathan Cameron
2016-01-25 22:24 ` [PATCH 07/22] fpga: " Richard Weinberger
2016-01-25 22:24   ` [uml-devel] " Richard Weinberger
2016-01-25 23:33   ` Moritz Fischer
2016-01-25 22:24 ` [PATCH 08/22] hwtracing: " Richard Weinberger
2016-01-25 22:24   ` [uml-devel] " Richard Weinberger
2016-02-05 14:07   ` Alexander Shishkin
2016-01-25 22:24 ` [PATCH 09/22] leds: " Richard Weinberger
2016-01-25 22:24   ` [uml-devel] " Richard Weinberger
2016-01-25 22:24   ` Richard Weinberger
2016-01-25 22:42   ` Richard Weinberger
2016-01-25 22:24 ` [PATCH 10/22] mailbox: " Richard Weinberger
2016-01-25 22:24   ` [uml-devel] " Richard Weinberger
2016-01-25 22:24 ` [PATCH 11/22] mtd: " Richard Weinberger
2016-01-26 11:00   ` Geert Uytterhoeven
2016-01-26 19:31     ` Brian Norris
2016-01-25 22:24 ` [PATCH 12/22] nvmem: " Richard Weinberger
2016-01-25 22:24   ` [uml-devel] " Richard Weinberger
2016-01-26 11:19   ` Srinivas Kandagatla
2016-01-26 14:20     ` Richard Weinberger
2016-01-25 22:24 ` [PATCH 13/22] net: " Richard Weinberger
2016-01-25 22:24   ` Richard Weinberger
2016-01-26 23:15   ` Noam Camus
2016-01-26 23:15     ` Noam Camus
2016-01-29  0:03   ` David Miller
2016-01-25 22:24 ` [PATCH 14/22] pwm: " Richard Weinberger
2016-01-25 22:24   ` Richard Weinberger
2016-01-25 22:40   ` Richard Weinberger
2016-01-25 22:24 ` [PATCH 15/22] watchdog: " Richard Weinberger
2016-01-26  2:47   ` Guenter Roeck
2016-01-25 22:24 ` [PATCH 16/22] iio: imu: " Richard Weinberger
2016-01-26  0:15   ` Paul Bolle
2016-01-26  8:17     ` Richard Weinberger [this message]
2016-01-30 15:49       ` Jonathan Cameron
2016-01-25 22:24 ` [PATCH 17/22] media: " Richard Weinberger
2016-02-01 13:26   ` Mauro Carvalho Chehab
2016-01-25 22:24 ` [PATCH 18/22] irqchip: " Richard Weinberger
2016-01-26 15:04   ` [tip:irq/urgent] irqchip: Fix dependencies for archs w/ o HAS_IOMEM tip-bot for Richard Weinberger
2016-01-25 22:24 ` [PATCH 19/22] thermal: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-25 22:24   ` Richard Weinberger
2016-01-25 22:24 ` [PATCH 20/22] clocksource: " Richard Weinberger
2016-01-26 15:40   ` [tip:timers/urgent] clocksource: Fix dependencies for archs w/ o HAS_IOMEM tip-bot for Richard Weinberger
2016-01-25 22:24 ` [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs Richard Weinberger
2016-01-26 11:00   ` Geert Uytterhoeven
2016-01-26 13:58     ` Richard Weinberger
2016-02-01 17:38       ` Brian Norris
2016-01-25 22:24 ` [PATCH 22/22] um: Export pm_power_off Richard Weinberger
2016-01-25 22:24   ` [uml-devel] " Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A72BB3.9090206@nod.at \
    --to=richard@nod.at \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=pmeerw@pmeerw.net \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.