From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/6] drm/i915: Kconfig for extra driver debugging
Date: Tue, 2 Feb 2016 11:09:15 +0000 [thread overview]
Message-ID: <56B08E5B.3010809@linux.intel.com> (raw)
In-Reply-To: <87h9hrsb4m.fsf@intel.com>
On 02/02/16 09:40, Jani Nikula wrote:
> On Tue, 02 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>> On 02/02/16 09:18, Jani Nikula wrote:
>>> On Mon, 01 Feb 2016, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/Kconfig | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
>>>> index 051eab33e4c7..7636bf918d97 100644
>>>> --- a/drivers/gpu/drm/i915/Kconfig
>>>> +++ b/drivers/gpu/drm/i915/Kconfig
>>>> @@ -47,3 +47,15 @@ config DRM_I915_PRELIMINARY_HW_SUPPORT
>>>> option changes the default for that module option.
>>>>
>>>> If in doubt, say "N".
>>>> +
>>>> +config DRM_I915_DEBUG
>>>> + bool "Enable additional driver debugging"
>>>> + depends on DRM_I915
>>>> + default n
>>>> + help
>>>> + Choose this option to turn on extra driver debugging that may affect
>>>> + performance but will catch some internal issues.
>>>> +
>>>> + Recommended for driver developers only.
>>>> +
>>>> + If in doubt, say "N".
>>>
>>> I kind of liked Chris' approach of adding a submenu
>>> http://patchwork.freedesktop.org/patch/msgid/1451902412-25459-1-git-send-email-chris@chris-wilson.co.uk
>>
>> I don't mind either way - what was decided for that patch - is it
>> going in?
>
> I think we'd like to have it, but last time it blew up on
> randconfig. Chris, do we avoid that now?
>
> Tvrtko, in any case, you could pick up the submenu part from there.
I have - and also respun the enlarged series of misc fixes and debugging
infrastructure. Reviewers welcome. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-02 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 16:27 [PATCH 1/6] drm/i915: Add wait_for_us Tvrtko Ursulin
2016-02-01 16:27 ` [PATCH 2/6] drm/i915: Do not wait atomically for display clocks Tvrtko Ursulin
2016-02-01 16:58 ` Ville Syrjälä
2016-02-01 16:27 ` [PATCH 3/6] drm/i915/guc: Do not wait for firmware load atomically Tvrtko Ursulin
2016-02-01 16:27 ` [PATCH 4/6] drm/i915/lrc: Do not wait atomically when stopping engines Tvrtko Ursulin
2016-02-01 16:27 ` [PATCH 5/6] drm/i915: Kconfig for extra driver debugging Tvrtko Ursulin
2016-02-02 9:18 ` Jani Nikula
2016-02-02 9:32 ` Tvrtko Ursulin
2016-02-02 9:40 ` Jani Nikula
2016-02-02 11:09 ` Tvrtko Ursulin [this message]
2016-02-01 16:27 ` [PATCH 6/6] drm/i915: Do not lie about atomic wait granularity Tvrtko Ursulin
2016-02-01 16:45 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Add wait_for_us Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B08E5B.3010809@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.