All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org,
	jingoohan1@gmail.com, dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	linux-rockchip@lists.infradead.org, kgene@kernel.org,
	benjamin.gaignard@linaro.org, vincent.abriou@st.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/17] drm/virtio: removed optional dummy encoder mode_fixup function.
Date: Mon, 15 Feb 2016 12:29:00 +0000	[thread overview]
Message-ID: <56C1C48C.1050006__276.297718710516$1455539368$gmane$org@synopsys.com> (raw)
In-Reply-To: <20160214182508.GF11240@phenom.ffwll.local>

Daniel, thanks for the feedback.
v2 patch will follow-up. :)

On 14-02-2016 18:25, Daniel Vetter wrote:
> On Fri, Feb 12, 2016 at 01:50:53PM +0000, Carlos Palminha wrote:
>
> Sob-line from you is missing on all patches, I can't merge them. Also
> please copypaste a default blurb to all patches that this is only recently
> no longer needed. And dunno what happened to your patch series, the
> threading is somehow broken. In case your mail server doesn't accept a big
> patch series you can first format .patch files using git format-patch with
> threading enabled (should be the default) and then send them out in
> chunks.
>
> When resending please also add the r-b tag from Alex for amdgpu/radoen.
>
> Thanks, Daniel
>
>> ---
>>   drivers/gpu/drm/virtio/virtgpu_display.c | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
>> index a165f03..429aa31 100644
>> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
>> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
>> @@ -282,13 +282,6 @@ static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = {
>>   	.atomic_check  = virtio_gpu_crtc_atomic_check,
>>   };
>>
>> -static bool virtio_gpu_enc_mode_fixup(struct drm_encoder *encoder,
>> -				      const struct drm_display_mode *mode,
>> -				      struct drm_display_mode *adjusted_mode)
>> -{
>> -	return true;
>> -}
>> -
>>   static void virtio_gpu_enc_mode_set(struct drm_encoder *encoder,
>>   				    struct drm_display_mode *mode,
>>   				    struct drm_display_mode *adjusted_mode)
>> @@ -362,7 +355,6 @@ virtio_gpu_best_encoder(struct drm_connector *connector)
>>   }
>>
>>   static const struct drm_encoder_helper_funcs virtio_gpu_enc_helper_funcs = {
>> -	.mode_fixup = virtio_gpu_enc_mode_fixup,
>>   	.mode_set   = virtio_gpu_enc_mode_set,
>>   	.enable     = virtio_gpu_enc_enable,
>>   	.disable    = virtio_gpu_enc_disable,
>> --
>> 2.5.0
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

  parent reply	other threads:[~2016-02-15 12:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <daniel.vetter@ffwll.ch,>
2016-02-12 13:50 ` [PATCH 00/17] drm encoders cleanup: nuke optional dummy encoder mode_fixup function Carlos Palminha
2016-02-12 13:50   ` Carlos Palminha
2016-02-12 13:50   ` [PATCH 01/17] drm/virtio: removed " Carlos Palminha
2016-02-12 13:50   ` Carlos Palminha
2016-02-12 13:50     ` Carlos Palminha
2016-02-14 18:25     ` Daniel Vetter
2016-02-14 18:25       ` Daniel Vetter
2016-02-15 12:29       ` Carlos Palminha
2016-02-15 12:29         ` Carlos Palminha
2016-02-15 12:29       ` Carlos Palminha [this message]
2016-02-14 18:25     ` Daniel Vetter
2016-02-12 13:50   ` [PATCH 02/17] drm/udl: " Carlos Palminha
2016-02-12 13:50     ` Carlos Palminha
2016-02-12 13:50   ` Carlos Palminha
2016-02-12 13:50   ` [PATCH 03/17] drm/exynos: " Carlos Palminha
2016-02-12 13:50   ` Carlos Palminha
2016-02-12 13:50     ` Carlos Palminha
2016-02-12 13:50   ` [PATCH 04/17] drm/amdgpu: " Carlos Palminha
2016-02-12 13:50     ` Carlos Palminha
2016-02-12 16:31     ` Alex Deucher
2016-02-12 16:31     ` Alex Deucher
2016-02-12 16:31       ` Alex Deucher
2016-02-12 13:50   ` Carlos Palminha
2016-02-12 13:50 ` [PATCH 00/17] drm encoders cleanup: nuke " Carlos Palminha
2016-02-12 13:50 Carlos Palminha
2016-02-12 13:50 ` [PATCH 01/17] drm/virtio: removed " Carlos Palminha
2016-02-12 13:50   ` Carlos Palminha
2016-02-12 13:50 ` Carlos Palminha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='56C1C48C.1050006__276.297718710516$1455539368$gmane$org@synopsys.com' \
    --to=carlos.palminha@synopsys.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=vincent.abriou@st.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.