Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list() - Vladimir Sementsov-Ogievskiy

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list()
Date: Thu, 25 Feb 2016 12:54:43 +0300	[thread overview]
Message-ID: <56CECF63.5060002@virtuozzo.com> (raw)
In-Reply-To: <20160225110947-mutt-send-email-mst@redhat.com>

On 25.02.2016 12:11, Michael S. Tsirkin wrote:
> On Thu, Feb 25, 2016 at 11:55:56AM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> On 25.02.2016 11:39, Michael S. Tsirkin wrote:
>>> On Thu, Feb 25, 2016 at 10:01:18AM +0300, Vladimir Sementsov-Ogievskiy wrote:
>>>> Stop!
>>> It builds fine here. Did you check out my tree?
>> anyway, this file should be here, as it is added into Makefile:
>>
>> --- a/stubs/Makefile.objs
>> +++ b/stubs/Makefile.objs
>> @@ -35,7 +35,7 @@ stub-obj-y += vmstate.o
>>   stub-obj-$(CONFIG_WIN32) += fd-register.o
>>   stub-obj-y += cpus.o
>>   stub-obj-y += kvm.o
>> -stub-obj-y += qmp_pc_dimm_device_list.o
>> +stub-obj-y += pc_dimm.o
>>   stub-obj-y += target-monitor-defs.o
>>   stub-obj-y += target-get-monitor-def.o
>>   stub-obj-y += vhost.o
>>
> Hmm that's right.
> Thanks!
> Looks like it was picking up an old object in the filesystem :(
> I'll respin - for now, does everything work for you if you drop
> this line from the makefile?

it will break compilation for targets without memory hotplug, it was 
discussed on list. stubs are necessary.

>
>> ===========
>> git clone git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tmp
>> cd tmp/
>> git checkout for_upstream
>> ./configure  --target-list=x86_64-softmmu
>> make -j9
>>> make: *** No rule to make target `stubs/pc_dimm.o', needed by
>> `libqemustub.a'.  Stop

-- 
Best regards,
Vladimir