From: Richard Henderson <rth@twiddle.net>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com,
qemu-devel@nongnu.org, aurelien@aurel32.net, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit output
Date: Thu, 3 Mar 2016 12:56:44 -0800 [thread overview]
Message-ID: <56D8A50C.1070604@twiddle.net> (raw)
In-Reply-To: <87a8mflkt3.fsf@linaro.org>
On 03/03/2016 06:04 AM, Alex Bennée wrote:
>
> Richard Henderson <rth@twiddle.net> writes:
>
>> On 02/22/2016 07:59 AM, Alex Bennée wrote:
>>> + qemu_set_dfilter_ranges("0x1000+0x100");
>>> +
>>> + g_assert_false(qemu_log_in_addr_range(0xfff));
>>> + g_assert(qemu_log_in_addr_range(0x1000));
>>> + g_assert(qemu_log_in_addr_range(0x1100));
>>
>> This is exactly what I was talking about wrt off-by-one error in my first
>> review -- 0x100 bytes, including 0x1000, finishes at 0x10ff.
>>
>> This third test should fail.
>
> OK so should 0x100+0x0 fail as it makes no sense, 0 bytes from 0x100 start?
Yes, I would think so.
r~
next prev parent reply other threads:[~2016-03-03 20:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 15:59 [Qemu-devel] [PATCH v7 0/9] qemu-log, -dfilter and other logging tweaks Alex Bennée
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 1/9] tcg: pass down TranslationBlock to tcg_code_gen Alex Bennée
2016-02-26 20:19 ` Richard Henderson
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 2/9] qemu-log: correct help text for -d cpu Alex Bennée
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 3/9] qemu-log: Avoid function call for disabled qemu_log_mask logging Alex Bennée
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 4/9] qemu-log: Improve the "exec" TB execution logging Alex Bennée
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit output Alex Bennée
2016-02-26 20:25 ` Richard Henderson
2016-03-03 14:04 ` Alex Bennée
2016-03-03 20:56 ` Richard Henderson [this message]
2016-03-03 23:33 ` Peter Maydell
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 6/9] qemu-log: dfilter-ise exec, out_asm, op and opt_op Alex Bennée
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 7/9] target-arm: dfilter support for in_asm Alex Bennée
2016-02-26 20:20 ` Richard Henderson
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 8/9] qemu-log: support simple pid substitution for logs Alex Bennée
2016-02-26 20:21 ` Richard Henderson
2016-02-22 15:59 ` [Qemu-devel] [PATCH v7 9/9] cputlb: modernise the debug support Alex Bennée
2016-02-26 10:57 ` [Qemu-devel] [PATCH v7 0/9] qemu-log, -dfilter and other logging tweaks Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8A50C.1070604@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crosthwaitepeter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.