Re: [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work

From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>, Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org
Cc: kwolf@redhat.com,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work
Date: Fri, 11 Mar 2016 14:30:37 -0500	[thread overview]
Message-ID: <56E31CDD.3080906@redhat.com> (raw)
In-Reply-To: <56E2CEAC.3090407@redhat.com>


On 03/11/2016 08:57 AM, Max Reitz wrote:
> On 08.03.2016 05:44, Fam Zheng wrote:
>> v4: Rebase.
>>     Add rev-by from John in patches 1-5, 7, 8.
>>     Remove BdrvDirtyBitmap typedef from dirty-bitmap.h in patch 4. [Max]
>>     Add assertion on bm->meta in patch 9. [John]
>>
>> Two major features are added to block dirty bitmap (and underlying HBitmap) in
>> this series: meta bitmap and serialization, together with all other supportive
>> patches.
>>
>> Both operations are common in dirty bitmap migration and persistence: they need
>> to find whether and which part of the dirty bitmap in question has changed with
>> meta dirty bitmap, and they need to write it to the target with serialization.
>>
>>
>> Fam Zheng (13):
>>   backup: Use Bitmap to replace "s->bitmap"
>>   block: Include hbitmap.h in block.h
>>   typedefs: Add BdrvDirtyBitmap
>>   block: Move block dirty bitmap code to separate files
>>   block: Remove unused typedef of BlockDriverDirtyHandler
>>   block: Hide HBitmap in block dirty bitmap interface
>>   HBitmap: Introduce "meta" bitmap to track bit changes
>>   tests: Add test code for meta bitmap
>>   block: Support meta dirty bitmap
>>   block: Add two dirty bitmap getters
>>   block: Assert that bdrv_release_dirty_bitmap succeeded
>>   tests: Add test code for hbitmap serialization
>>   block: More operations for meta dirty bitmap
>>
>> Vladimir Sementsov-Ogievskiy (2):
>>   hbitmap: serialization
>>   block: BdrvDirtyBitmap serialization interface
>>
>>  block.c                      | 360 -----------------------------
>>  block/Makefile.objs          |   2 +-
>>  block/backup.c               |  25 +-
>>  block/dirty-bitmap.c         | 535 +++++++++++++++++++++++++++++++++++++++++++
>>  block/mirror.c               |  15 +-
>>  include/block/block.h        |  40 +---
>>  include/block/dirty-bitmap.h |  75 ++++++
>>  include/qemu/hbitmap.h       |  96 ++++++++
>>  include/qemu/typedefs.h      |   2 +
>>  tests/test-hbitmap.c         | 255 +++++++++++++++++++++
>>  util/hbitmap.c               | 203 ++++++++++++++--
>>  11 files changed, 1177 insertions(+), 431 deletions(-)
>>  create mode 100644 block/dirty-bitmap.c
>>  create mode 100644 include/block/dirty-bitmap.h
> 
> Thanks, applied patches 1 through 5 to my block tree (because of the
> large code movement in patch 4):
> 
> https://github.com/XanClic/qemu/commits/block
> 
> Max
> 

You're a saint, thank you :)