From: Steve Dickson <SteveD@redhat.com>
To: NeilBrown <neilb@suse.com>
Cc: Benjamin Coddington <bcodding@redhat.com>,
Linux NFS mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH - nfs-utils] systemd: ensure nfs-config service is re-run as needed.
Date: Wed, 16 Mar 2016 14:23:14 -0400 [thread overview]
Message-ID: <56E9A492.1090106@RedHat.com> (raw)
In-Reply-To: <87fuvrfbof.fsf@notabene.neil.brown.name>
On 03/15/2016 09:34 PM, NeilBrown wrote:
>
> The nfs-config service translates distro-specific startup
> configuration into "environment" variable read and used
> by systemd unit files.
>
> Currently it is only run once, so subsequent changes to the
> distro-specific files do not take effect when an nfs service is
> restarted.
>
> If we change "RemainAfterExit=yes" to "RemainAfterExit=no" then the
> service will be restarted before any dependant service is started, so
> the environment file will always be up to date.
>
> Reported-and-tested-by: Benjamin Coddington <bcodding@redhat.com>
> Signed-off-by: NeilBrown <neilb@suse.com>
Committed... Nice Work!!!
steved.
> ---
> systemd/nfs-config.service | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/systemd/nfs-config.service b/systemd/nfs-config.service
> index 7f653058f424..e0a7f83314f5 100644
> --- a/systemd/nfs-config.service
> +++ b/systemd/nfs-config.service
> @@ -5,5 +5,9 @@ DefaultDependencies=no
>
> [Service]
> Type=oneshot
> -RemainAfterExit=yes
> +# This service needs to run any time any nfs service
> +# is started, so changes to local config files get
> +# incorporated. Having "RemainAfterExit=no" (the default)
> +# ensures this happens.
> +RemainAfterExit=no
> ExecStart=/usr/lib/systemd/scripts/nfs-utils_env.sh
>
prev parent reply other threads:[~2016-03-16 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 1:34 [PATCH - nfs-utils] systemd: ensure nfs-config service is re-run as needed NeilBrown
2016-03-16 18:23 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9A492.1090106@RedHat.com \
--to=steved@redhat.com \
--cc=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.