Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation. - Jean-Christophe DUBOIS

From: Jean-Christophe DUBOIS <jcd@tribudubois.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 6/6] i.MX: Add sabrelite i.MX6 emulation.
Date: Thu, 24 Mar 2016 08:11:03 +0100	[thread overview]
Message-ID: <56F39307.5000400@tribudubois.net> (raw)
In-Reply-To: <CAFEAcA8yrhFCbvC_k1bpm9pnDzxm4M5s5XExRdNZBRuxyLegcA@mail.gmail.com>

Le 23/03/2016 15:48, Peter Maydell a écrit :
> On 19 March 2016 at 20:59, Jean-Christophe Dubois <jcd@tribudubois.net> wrote:
>> The sabrelite supports one SPI FLASH memory on SPI1
>>
>> Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
>> +    {
>> +        /* Add the sst25vf016b NOR FLASH memory to first SPI */
>> +        Object *spi_dev;
>> +
>> +        spi_dev = object_resolve_path_component(OBJECT(&s->soc), "spi1");
> Can you add a comment to remind us there's a todo here:
>   /* Ideally we would expose the chip select and spi bus on the SoC
>    * object using alias properties; then we would not need to directly
>    * access the underlying spi device object.
>    */
OK
>
> Otherwise
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM
>