All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH v4 1/5] libxl: Remove pointless hypercall from libxl_set_memory_target
Date: Thu, 24 Mar 2016 16:54:52 +0000	[thread overview]
Message-ID: <56F41BDC.9090202@citrix.com> (raw)
In-Reply-To: <22154.43976.129934.503875@mariner.uk.xensource.com>

On 04/01/16 17:28, Ian Jackson wrote:
> George Dunlap writes ("[PATCH v4 1/5] libxl: Remove pointless hypercall from libxl_set_memory_target"):
>> There's no obvious reason for the call to xc_domain_getinfolist -- all
>> it seems to be doing is checking that the domain exists; but if it
>> doesn't exist, it will have already failed by this point.
>>
>> NB that this will change the return value for libxl_set_memory_target:
>> now it will return 0 on success, rather than returning 1 (which was
>> the previous behavior).  This is more in line with expected behavior,
>> and also allows the caller to distingiush between success and other
>> failure modes (some of which also return 1).
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> Although I don't see the other return paths returning 1 which you
> mention.

rc is initialized to 1, and there are a number of exit paths (I count 7)
which jump to out without setting it; including setting the target above
static_max.

BTW I'm about to re-send the Ack'ed patches in this series (rebased to
staging).

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-03-24 16:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 12:23 [PATCH v4 0/5] Return failure on failure for more xl commands George Dunlap
2015-12-18 12:23 ` [PATCH v4 1/5] libxl: Remove pointless hypercall from libxl_set_memory_target George Dunlap
2016-01-04 17:28   ` Ian Jackson
2016-03-24 16:54     ` George Dunlap [this message]
2015-12-18 12:23 ` [PATCH v4 2/5] libxl: Fix libxl_set_memory_target return value George Dunlap
2016-01-04 17:37   ` Ian Jackson
2016-01-05 14:54     ` Ian Campbell
2016-01-05 15:21       ` Ian Jackson
2015-12-18 12:23 ` [PATCH v4 3/5] xl: Make set_memory_target return an error code on failure George Dunlap
2015-12-21 10:52   ` Dario Faggioli
2016-01-04 17:37   ` Ian Jackson
2015-12-18 12:23 ` [PATCH v4 4/5] xl: Return an error on failed cd-insert George Dunlap
2015-12-21 10:52   ` Dario Faggioli
2016-01-04 17:38   ` Ian Jackson
2015-12-18 12:23 ` [PATCH v4 5/5] xl: Return error codes for pci* commands George Dunlap
2015-12-21 10:51   ` Dario Faggioli
2016-01-04 17:40   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F41BDC.9090202@citrix.com \
    --to=george.dunlap@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.