From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86emul: don't allow INVLPG in real mode
Date: Fri, 22 Apr 2016 09:09:14 -0600 [thread overview]
Message-ID: <571A5ABB02000078000E4D9B@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160422144055.GN27627@citrix.com>
>>> On 22.04.16 at 16:40, <wei.liu2@citrix.com> wrote:
> On Fri, Apr 22, 2016 at 08:17:35AM -0600, Jan Beulich wrote:
>> As both INVLPG and INVLPGA have basically the same exception rules
>> (leaving aside that INVLPGA requires SVME enabled, which so far isn't
>> being taken care of, and that INVLPG requires ModRM.mod != 3), fold
>> the handling of the two as much as possible alongside achieving the
>> goal of the patch (at once doing the #UD checks pror to the #GP one,
>> which ought to be more in line with how hardware does things).
>>
>> But please note that AMD and Intel disagree on what exceptions INVLPG
>> may raise, and the more reasonable Intel variant is being followed.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>
> So this patch supersedes Andrew's patch to fix invlpg on AMD with shadow
> paging?
No, it is addressing an issue I found while reviewing Andrew's.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-22 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 14:17 [PATCH] x86emul: don't allow INVLPG in real mode Jan Beulich
2016-04-22 14:40 ` Wei Liu
2016-04-22 15:09 ` Jan Beulich [this message]
2016-04-22 16:08 ` Andrew Cooper
2016-04-25 7:28 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571A5ABB02000078000E4D9B@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.