Re: [ndctl PATCH 4/8] ndctl, create-namespace: report failures due to namespace being mounted

From: Linda Knippers <linda.knippers@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Subject: Re: [ndctl PATCH 4/8] ndctl, create-namespace: report failures due to namespace being mounted
Date: Fri, 22 Apr 2016 19:00:17 -0400	[thread overview]
Message-ID: <571AAD01.3080801@hpe.com> (raw)
In-Reply-To: <146135444310.4228.7151000859132505494.stgit@dwillia2-desk3.amr.corp.intel.com>

On 4/22/2016 3:47 PM, Dan Williams wrote:
> In the case when a filesystem is mounted on a namespace targeted for
> reconfiguration or destruction, emit a message so the user knows to
> unmount the filesystem.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  builtin-xaction-namespace.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/builtin-xaction-namespace.c b/builtin-xaction-namespace.c
> index 53ff82bc2c8d..e2e6d518c64d 100644
> --- a/builtin-xaction-namespace.c
> +++ b/builtin-xaction-namespace.c
> @@ -550,6 +550,8 @@ static int namespace_destroy(struct ndctl_region *region,
>  			 * stopping the !bdev case from racing to mount an fs or
>  			 * re-enabling the namepace.
>  			 */
> +			error("%s: %s is mounted, failing operation\n",
> +					devname, bdev);

I'm seeing this error message in cases where the device is not mounted,
such as when I forget to run ndctl as root/sudo.  That's a more
likely reason that the open() may fail.  Perhaps you could check the
errno from the open() failure and display an error based on that?
You might simply do a perror().

-- ljk

>  			return -EBUSY;
>  		}
>  	}
> 
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm