From: Timo Aaltonen <tjaalton@ubuntu.com>
To: Hans de Goede <hdegoede@redhat.com>, intel-gfx@lists.freedesktop.org
Cc: Rob Clark <rclark@redhat.com>, Adam Jackson <ajax@redhat.com>
Subject: Re: [PATCH xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails
Date: Mon, 25 Apr 2016 11:38:09 +0300 [thread overview]
Message-ID: <571DD771.8040004@ubuntu.com> (raw)
In-Reply-To: <1461348273-25895-1-git-send-email-hdegoede@redhat.com>
22.04.2016, 21:04, Hans de Goede kirjoitti:
> The probe functions in intel_module.c call intel_open_device() before
> calling intel_scrn_create(), but if the later fails because of e.g.
> an unsupported (new) pci-id they were not cleaning up the resources
> claimed by intel_open_device(), esp. leaking the fd is a problem
> because this breaks the fallback to the modesetting driver.
>
> This commit fixes this by adding a intel_close_device() cleanup
> function and calling that when intel_scrn_create() fails.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Thanks, fixed the fallback here too.
--
t
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-25 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 18:04 [PATCH xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails Hans de Goede
2016-04-25 8:38 ` Timo Aaltonen [this message]
2016-05-12 17:57 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571DD771.8040004@ubuntu.com \
--to=tjaalton@ubuntu.com \
--cc=ajax@redhat.com \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rclark@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.