From: Loic PALLARDY <loic.pallardy@st.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>
Cc: "ohad@wizery.com" <ohad@wizery.com>,
"s-anna@ti.com" <s-anna@ti.com>,
"peng.fan@nxp.com" <peng.fan@nxp.com>,
Arnaud POULIQUEN <arnaud.pouliquen@st.com>,
Fabien DESSENNE <fabien.dessenne@st.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>
Subject: RE: [PATCH 02/11] remoteproc: stm32: Request IRQ with platform device
Date: Fri, 27 Mar 2020 16:54:45 +0000 [thread overview]
Message-ID: <57220cc7d0a6447c84435ff7e39cf303@SFHDAG7NODE2.st.com> (raw)
In-Reply-To: <20200324220329.15523-3-mathieu.poirier@linaro.org>
> -----Original Message-----
> From: Mathieu Poirier <mathieu.poirier@linaro.org>
> Sent: mardi 24 mars 2020 23:03
> To: bjorn.andersson@linaro.org
> Cc: ohad@wizery.com; Loic PALLARDY <loic.pallardy@st.com>; s-
> anna@ti.com; peng.fan@nxp.com; Arnaud POULIQUEN
> <arnaud.pouliquen@st.com>; Fabien DESSENNE
> <fabien.dessenne@st.com>; linux-remoteproc@vger.kernel.org
> Subject: [PATCH 02/11] remoteproc: stm32: Request IRQ with platform
> device
>
> Request IRQ with platform device rather than remote proc in order to
> call stm32_rproc_parse_dt() before rproc_alloc(). That way we can
> know whether we need to synchronise with the MCU or not.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Thanks Mathieu
Reviewed-by: Loic Pallardy <loic.pallardy@st.com>
> ---
> drivers/remoteproc/stm32_rproc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c
> b/drivers/remoteproc/stm32_rproc.c
> index cde4b1a56381..0c1f0b84e057 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -261,7 +261,8 @@ static int stm32_rproc_parse_fw(struct rproc *rproc,
> const struct firmware *fw)
>
> static irqreturn_t stm32_rproc_wdg(int irq, void *data)
> {
> - struct rproc *rproc = data;
> + struct platform_device *pdev = data;
> + struct rproc *rproc = platform_get_drvdata(pdev);
>
> rproc_report_crash(rproc, RPROC_WATCHDOG);
>
> @@ -553,7 +554,7 @@ static int stm32_rproc_parse_dt(struct
> platform_device *pdev)
>
> if (irq > 0) {
> err = devm_request_irq(dev, irq, stm32_rproc_wdg, 0,
> - dev_name(dev), rproc);
> + dev_name(dev), pdev);
> if (err) {
> dev_err(dev, "failed to request wdg irq\n");
> return err;
> --
> 2.20.1
next prev parent reply other threads:[~2020-03-27 16:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 22:03 [PATCH 00/11] remoteproc: stm32: Add support for synchronisation with MCU Mathieu Poirier
2020-03-24 22:03 ` [PATCH 01/11] remoteproc: stm32: Decouple rproc from memory translation Mathieu Poirier
2020-03-27 16:51 ` Loic PALLARDY
2020-03-24 22:03 ` [PATCH 02/11] remoteproc: stm32: Request IRQ with platform device Mathieu Poirier
2020-03-27 16:54 ` Loic PALLARDY [this message]
2020-03-24 22:03 ` [PATCH 03/11] remoteproc: stm32: Decouple rproc from DT parsing Mathieu Poirier
2020-03-27 16:55 ` Loic PALLARDY
2020-03-24 22:03 ` [PATCH 04/11] remoteproc: stm32: Remove memory translation " Mathieu Poirier
2020-03-27 16:55 ` Loic PALLARDY
2020-03-24 22:03 ` [PATCH 05/11] remoteproc: stm32: Parse syscon that will manage M4 synchronisation Mathieu Poirier
2020-03-27 16:56 ` Loic PALLARDY
2020-03-24 22:03 ` [PATCH 06/11] remoteproc: stm32: Get coprocessor state Mathieu Poirier
2020-03-27 16:58 ` Loic PALLARDY
2020-03-30 22:44 ` Mathieu Poirier
2020-03-24 22:03 ` [PATCH 07/11] remoteproc: stm32: Get loaded resource table for synchronisation Mathieu Poirier
2020-03-27 16:59 ` Loic PALLARDY
2020-03-24 22:03 ` [PATCH 08/11] remoteproc: stm32: Introduce new start and stop ops " Mathieu Poirier
2020-03-27 17:04 ` Loic PALLARDY
2020-03-30 22:56 ` Mathieu Poirier
2020-03-24 22:03 ` [PATCH 09/11] remoteproc: stm32: Introduce new parse fw " Mathieu Poirier
2020-03-27 17:05 ` Loic PALLARDY
2020-03-24 22:03 ` [PATCH 10/11] remoteproc: stm32: Introduce new loaded rsc " Mathieu Poirier
2020-03-27 17:05 ` Loic PALLARDY
2020-03-24 22:03 ` [PATCH 11/11] remoteproc: stm32: Allocate rproc for synchronisation with MCU Mathieu Poirier
2020-03-27 17:11 ` Loic PALLARDY
2020-03-27 21:49 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57220cc7d0a6447c84435ff7e39cf303@SFHDAG7NODE2.st.com \
--to=loic.pallardy@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.dessenne@st.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.