From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_new() call
Date: Tue, 17 May 2016 09:23:23 -0600 [thread overview]
Message-ID: <573B376B.4070003@redhat.com> (raw)
In-Reply-To: <1463496094-21608-2-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On 05/17/2016 08:41 AM, Max Reitz wrote:
> bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS
> before invoking bdrv_open() on that BDS. This is probably a relict from
s/relict/relic/
> when it used to do some modifications on that empty BDS, but now that is
> unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open()
> do the rest.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-05-17 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 14:41 [Qemu-devel] [PATCH v4 0/9] blockdev: (Nearly) free clean-up work Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_new() call Max Reitz
2016-05-17 15:23 ` Eric Blake [this message]
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 2/9] block: Let bdrv_open_inherit() return the snapshot Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 3/9] tests: Drop BDS from test-throttle.c Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 4/9] block: Drop blk_new_with_bs() Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 5/9] block: Drop bdrv_new_root() Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 6/9] block: Make bdrv_open() return a BDS Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 7/9] block: Assert !bs->refcnt in bdrv_close() Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 8/9] block: Drop bdrv_parent_cb_...() from bdrv_close() Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 9/9] block: Drop errp parameter from blk_new() Max Reitz
2016-05-23 11:09 ` [Qemu-devel] [PATCH v4 0/9] blockdev: (Nearly) free clean-up work Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573B376B.4070003@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.