From: "Jan Beulich" <jbeulich@suse.com>
To: kevin.tian@intel.com, quan.xu@intel.com
Cc: dario.faggioli@citrix.com, feng.wu@intel.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v10 1/3] vt-d: add a timeout parameter for Queued Invalidation
Date: Thu, 19 May 2016 00:13:06 -0600 [thread overview]
Message-ID: <573D678202000078000E8BE9@prv-mh.provo.novell.com> (raw)
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28894B8B23FB@SHSMSX101.ccr.corp.intel.com>
>>> "Xu, Quan" <quan.xu@intel.com> 05/19/16 3:35 AM >>>
>On May 19, 2016 8:33 AM, Tian, Kevin <kevin.tian@intel.com> wrote:
>> > From: Jan Beulich [mailto:JBeulich@suse.com]
>> > Sent: Wednesday, May 18, 2016 11:05 PM
>> > >>> On 18.05.16 at 14:53, <quan.xu@intel.com> wrote:
>> > The patch can imo remain as is only if the new default timeout is
>> > large enough for all possible cases (including those users who are
>> > adventurous enough to turn on ATS).
>
>I only have an ATS device (MYRICOM Inc. Myri-10G Dual-Protocol NIC). 1 ms is large enough for invalidation so far.
>Any suggestion for this new default timeout?
Unless you have theoretical proof that a lower than the current value would
suffice (as you do for the IOMMU side flushes), I think the default needs to
remain the same as it is right now (which iirc is already _much_ lower than
the real theoretical one).
>> A single default value for both IOMMU-side and device-side is anyway not
>> optimal. What about introducing a new knob e.g. vtd_qi_device_timeout
>> specifically for device-side flush while using vtd_qi_timeout for other places? If
>> device-side timeout is not specified, it is then default to vtd_qi_timeout.
There should imo be a single command line option, allowing for two values to be
passed (e.g. comma-separated).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-19 6:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 10:54 [PATCH v10 0/3] VT-d Device-TLB flush issue Quan Xu
2016-04-22 10:54 ` [PATCH v10 1/3] vt-d: add a timeout parameter for Queued Invalidation Quan Xu
2016-05-13 15:27 ` Jan Beulich
2016-05-16 15:25 ` Xu, Quan
2016-05-17 3:19 ` Tian, Kevin
2016-05-17 7:47 ` Jan Beulich
2016-05-18 12:53 ` Xu, Quan
2016-05-18 15:05 ` Jan Beulich
2016-05-19 0:32 ` Tian, Kevin
2016-05-19 1:35 ` Xu, Quan
2016-05-19 6:13 ` Jan Beulich [this message]
2016-05-19 11:26 ` Xu, Quan
2016-05-19 11:35 ` Jan Beulich
2016-05-19 15:14 ` Xu, Quan
2016-04-22 10:54 ` [PATCH v10 2/3] vt-d: synchronize for Device-TLB flush one by one Quan Xu
2016-05-17 12:36 ` Jan Beulich
2016-05-18 8:53 ` Xu, Quan
2016-05-18 9:29 ` Jan Beulich
2016-05-18 12:02 ` Xu, Quan
2016-04-22 10:54 ` [PATCH v10 3/3] vt-d: fix vt-d Device-TLB flush timeout issue Quan Xu
2016-05-17 14:00 ` Jan Beulich
2016-05-18 13:11 ` Xu, Quan
2016-05-20 7:15 ` Xu, Quan
2016-05-20 9:58 ` Jan Beulich
2016-05-23 14:00 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573D678202000078000E8BE9@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=kevin.tian@intel.com \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.