From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: mst@redhat.com, ooo@electrozaur.com, nab@linux-iscsi.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 3/7] block: ensure bios return from blk_get_request are properly initialized
Date: Wed, 15 Jun 2016 11:02:18 +0200 [thread overview]
Message-ID: <5761199A.1070400@kernel.dk> (raw)
In-Reply-To: <1465924564-14503-4-git-send-email-hch@lst.de>
On 06/14/2016 07:16 PM, Christoph Hellwig wrote:
> blk_get_request is used for BLOCK_PC and similar passthrough requests.
> Currently we always need to call blk_rq_set_block_pc or an open coded
> version of it to allow appending bios using the request mapping helpers
> later on, which is a somewhat awkward API. Instead move the
> initialization part of blk_rq_set_block_pc into blk_get_request, so that
> we always have a safe to use request.
This still puts the pc related memset() into the normal fast path...
--
Jens Axboe
next prev parent reply other threads:[~2016-06-15 9:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 17:15 a few passthrough request improvements V2 Christoph Hellwig
2016-06-14 17:15 ` [PATCH 1/7] memstick: don't allow REQ_TYPE_BLOCK_PC requests Christoph Hellwig
2016-06-14 17:15 ` [PATCH 2/7] virtio_blk: use blk_rq_map_kern Christoph Hellwig
2016-06-14 17:16 ` [PATCH 3/7] block: ensure bios return from blk_get_request are properly initialized Christoph Hellwig
2016-06-15 9:02 ` Jens Axboe [this message]
2016-06-15 10:07 ` Christoph Hellwig
2016-06-15 10:17 ` Jens Axboe
2016-06-15 10:25 ` Christoph Hellwig
2016-06-14 17:16 ` [PATCH 4/7] block: simplify and export blk_rq_append_bio Christoph Hellwig
2016-06-14 17:16 ` [PATCH 5/7] target: stop using blk_make_request Christoph Hellwig
2016-06-14 17:16 ` [PATCH 6/7] scsi/osd: open code blk_make_request Christoph Hellwig
2016-06-14 17:16 ` [PATCH 7/7] block: unexport various bio mapping helpers Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-07-19 9:31 resend: passthrough request improvements V3 Christoph Hellwig
2016-07-19 9:31 ` [PATCH 3/7] block: ensure bios return from blk_get_request are properly initialized Christoph Hellwig
2016-06-16 9:14 passthrough request improvements V3 Christoph Hellwig
2016-06-16 9:14 ` [PATCH 3/7] block: ensure bios return from blk_get_request are properly initialized Christoph Hellwig
2016-06-13 15:21 a few passthrough request improvements Christoph Hellwig
2016-06-13 15:21 ` [PATCH 3/7] block: ensure bios return from blk_get_request are properly initialized Christoph Hellwig
2016-06-14 2:17 ` Jens Axboe
2016-06-14 13:43 ` Christoph Hellwig
2016-06-14 15:04 ` Jens Axboe
2016-06-15 9:57 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5761199A.1070400@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=ooo@electrozaur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.