From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/7] drm/i915: Move common engine setup into intel_engine_cs.c
Date: Thu, 14 Jul 2016 10:25:39 +0100 [thread overview]
Message-ID: <57875A93.9050800@linux.intel.com> (raw)
In-Reply-To: <20160713160438.GL6157@nuc-i3427.alporthouse.com>
On 13/07/16 17:04, Chris Wilson wrote:
> On Wed, Jul 13, 2016 at 04:03:40PM +0100, Tvrtko Ursulin wrote:
>> + /*
>> + * Catch failures to update intel_engines table when the new engines
>> + * are added to the driver by a warning and disabling the forgotten
>> + * engines.
>> + */
>> + if (WARN_ON(mask != INTEL_INFO(dev_priv)->ring_mask)) {
>> + struct intel_device_info *info =
>> + (struct intel_device_info *)&dev_priv->info;
>
> I snuck in mkwrite_device_info(), so
>
> if (WARN_ON(mask != INTEL_INFO(dev_priv)->ring_mask))
> mkwrite_device_info(dev_priv)->ring_mask = mask;
This part is just code movement, the block you quote exists before this
series even!
Follow up patch to this series would be easiest then, or a solitary
precursor if you insist. Dangers of code movement with edits huh?
(94b4f3ba483ace6dd4a3f881e19cc18bdbafa6ef)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-07-14 9:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 15:03 [PATCH 1/7] drm/i915: unify first-stage engine struct setup Tvrtko Ursulin
2016-07-13 15:03 ` [PATCH 2/7] drm/i915: Prepare for engine init unification Tvrtko Ursulin
2016-07-13 15:03 ` [PATCH 3/7] drm/i915: Unify engine init loop Tvrtko Ursulin
2016-07-13 15:03 ` [PATCH 4/7] drm/i915: Make more use of the shared engine irq setup Tvrtko Ursulin
2016-07-13 15:03 ` [PATCH 5/7] drm/i915: Simplify intel_init_ring_buffer prototype Tvrtko Ursulin
2016-07-13 15:03 ` [PATCH 6/7] drm/i915: Move common engine setup into intel_engine_cs.c Tvrtko Ursulin
2016-07-13 16:04 ` Chris Wilson
2016-07-14 9:25 ` Tvrtko Ursulin [this message]
2016-07-14 10:07 ` Chris Wilson
2016-07-13 15:03 ` [PATCH 7/7] drm/i915: Pull out some more common engine init code Tvrtko Ursulin
2016-07-13 15:57 ` ✓ Ro.CI.BAT: success for series starting with [1/7] drm/i915: unify first-stage engine struct setup Patchwork
2016-07-14 10:20 ` Tvrtko Ursulin
2016-07-13 16:01 ` [PATCH 1/7] " Chris Wilson
2016-07-14 9:19 ` Tvrtko Ursulin
2016-07-14 10:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57875A93.9050800@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.