All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: Lars Kurth <lars.kurth@citrix.com>,
	Iurii Konovalenko <iurii.konovalenko@globallogic.com>,
	Volodymyr Babchuk <vlad.babchuk@gmail.com>,
	Tim Deegan <tim@xen.org>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	ian.jackson@eu.citrix.com, al1img@gmail.com,
	Andrii Anisov <andrii.anisov@gmail.com>,
	Oleksandr Tyshchenko <olekstysh@gmail.com>,
	embedded-pv-devel <embedded-pv-devel@lists.xenproject.org>,
	Julien Grall <julien.grall@arm.com>,
	David Vrabel <david.vrabel@citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>,
	Mygaiev Artem <joculator@gmail.com>
Subject: Re: [Embedded-pv-devel] [PATCH v9] xen: add para-virtual sound interface header files
Date: Thu, 24 Nov 2016 06:04:49 -0700	[thread overview]
Message-ID: <5836F3810200007800121B08@prv-mh.provo.novell.com> (raw)
In-Reply-To: <CANY+8dc0HHVUjQkGAwr=-e52Kv0DpX5pw3xt5V55phqJRi3Wqw@mail.gmail.com>

>>> On 24.11.16 at 13:53, <andr2000@gmail.com> wrote:
>>  Any people who wants to use the PV driver for other OS than Linux will have
>> to do it. So, may I ask why don't you write a platform agnostic header?
>>
>> This would also make easier to share the PV driver code between different
>> OS.
> There are 2 files: sndif.h which is platform agnostic and sndif_linux.h
> which is Linux platform specific (this is exactly the file which every 
> platform
> will need to define, e.g. sndif_windows.h).

But that is the very problem: There shouldn't be an assumption that
both side of the communication sit on the same OS, i.e. you need
one fully spelled out header, and that header ...

> In my case I need it to at least define Linux specific __packed
> attribute which is not supported by Win AFAIK.

... needs to avoid using platform specific constructs (or making
other assumptions on the platform). I can only re-iterate: Please
follow the model other PV protocols already present (without
repeating their mistakes, if at all possible).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-11-24 13:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 16:38 [PATCH v9] sndif: add ABI for para-virtual sound Oleksandr Andrushchenko
2016-11-23 16:38 ` [PATCH v9] xen: add para-virtual sound interface header files Oleksandr Andrushchenko
2016-11-24 10:58   ` Jan Beulich
2016-11-24 11:49     ` Oleksandr Andrushchenko
2016-11-24 12:15       ` Jan Beulich
2016-11-24 12:52         ` Oleksandr Andrushchenko
2016-11-24 13:02           ` Jan Beulich
2016-11-24 12:15       ` [Embedded-pv-devel] " Julien Grall
2016-11-24 12:53         ` Oleksandr Andrushchenko
2016-11-24 13:00           ` Julien Grall
2016-11-24 14:28             ` Oleksandr Andrushchenko
2016-11-24 13:04           ` Jan Beulich [this message]
2016-11-24 13:18             ` Artem Mygaiev
2016-11-24 13:31               ` Jan Beulich
2016-11-24 14:58                 ` Artem Mygaiev
2016-11-24 15:09                   ` Julien Grall
2016-11-24 15:50                     ` Artem Mygaiev
2016-11-24 16:08                       ` Julien Grall
2016-11-24 16:29                         ` Artem Mygaiev
2016-11-24 15:11                   ` Jan Beulich
2016-11-24 15:29                   ` Oleksandr Andrushchenko
2016-11-24 12:13   ` Julien Grall
2016-11-24 12:35     ` Oleksandr Andrushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5836F3810200007800121B08@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=al1img@gmail.com \
    --cc=andr2000@gmail.com \
    --cc=andrii.anisov@gmail.com \
    --cc=dario.faggioli@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=embedded-pv-devel@lists.xenproject.org \
    --cc=ian.jackson@eu.citrix.com \
    --cc=iurii.konovalenko@globallogic.com \
    --cc=joculator@gmail.com \
    --cc=julien.grall@arm.com \
    --cc=lars.kurth@citrix.com \
    --cc=oleksandr.dmytryshyn@globallogic.com \
    --cc=olekstysh@gmail.com \
    --cc=tim@xen.org \
    --cc=vlad.babchuk@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.