From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.cz>, <jbacik@fb.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH RFC v2 00/16] Introduce low memory usage btrfsck mode
Date: Wed, 11 May 2016 09:17:06 +0800 [thread overview]
Message-ID: <58406785-15b7-2888-124f-03a01a6a7d9a@cn.fujitsu.com> (raw)
In-Reply-To: <20160510124429.GR29353@twin.jikos.cz>
David Sterba wrote on 2016/05/10 14:44 +0200:
> On Fri, Apr 29, 2016 at 03:18:54PM +0800, Qu Wenruo wrote:
>> The branch can be fetched from my github:
>> https://github.com/adam900710/btrfs-progs.git low_mem_fsck_rebasing
> ...
>> Changelog:
>> v1.1:
>> Fix a typo which makes keyed data backref check always fail
>> v2:
>> Don't return minus value with error bits. (Suggested by Josef)
>> Follow kernel code styling. (Suggested by Josef)
>> Enhance check on data backref count. (Slow down check speed though)
>
> Is the branch low_mem_fsck_rebasing supposed to track the latest
> version? I still see the negative values for error flags there.
Sorry, forgot to update github repo.
Updated now.
>
> I guess last thing you'd like to see commented in this patchset is
> message formatting but it's consistently not matching the preferred
> style everywhere, so please don't start the message with capitals, eg.:
>
> error("Block group[%llu %llu] relat..."
>
> Testing the branch on the images in repository reported no problems
> which is enough to add the branch to integration, but otherwise I'll
> wait for Josef's review.
>
>
That's completely OK, review from Josef will definitely improve the code
quality.
And for message format, I'll change them in next iteration
Thanks,
Qu
prev parent reply other threads:[~2016-05-11 1:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 7:18 [PATCH RFC v2 00/16] Introduce low memory usage btrfsck mode Qu Wenruo
2016-04-29 7:18 ` [PATCH RFC v2 01/16] btrfs-progs: fsck: Introduce function to check tree block backref in extent tree Qu Wenruo
2016-04-29 7:18 ` [PATCH RFC v2 02/16] btrfs-progs: fsck: Introduce function to check data " Qu Wenruo
2016-04-29 7:18 ` [PATCH RFC v2 03/16] btrfs-progs: fsck: Introduce function to query tree block level Qu Wenruo
2016-04-29 7:18 ` [PATCH RFC v2 04/16] btrfs-progs: fsck: Introduce function to check referencer of a backref Qu Wenruo
2016-04-29 7:18 ` [PATCH RFC v2 05/16] btrfs-progs: fsck: Introduce function to check shared block ref Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 06/16] btrfs-progs: fsck: Introduce function to check referencer for data backref Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 07/16] btrfs-progs: fsck: Introduce function to check shared " Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 08/16] btrfs-progs: fsck: Introduce function to check an extent Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 09/16] btrfs-progs: fsck: Introduce function to check dev extent item Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 10/16] btrfs-progs: fsck: Introduce function to check dev used space Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 11/16] btrfs-progs: fsck: Introduce function to check block group item Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 12/16] btrfs-progs: fsck: Introduce function to check chunk item Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 13/16] btrfs-progs: fsck: Introduce hub function for later fsck Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 14/16] btrfs-progs: fsck: Introduce function to speed up fs tree check Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 15/16] btrfs-progs: fsck: Introduce traversal function for fsck Qu Wenruo
2016-04-29 7:19 ` [PATCH RFC v2 16/16] btrfs-progs: fsck: Introduce low memory mode Qu Wenruo
2016-04-29 7:27 ` [PATCH RFC v2 00/16] Introduce low memory usage btrfsck mode Qu Wenruo
2016-04-29 13:54 ` Josef Bacik
2016-05-10 12:44 ` David Sterba
2016-05-11 1:17 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58406785-15b7-2888-124f-03a01a6a7d9a@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.