From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 5/8] qcom: pmic_glink: enable altmode for SM8550
Date: Tue, 13 Jun 2023 13:54:08 +0200 [thread overview]
Message-ID: <5851627e-2972-f860-e965-dc8e73b01225@linaro.org> (raw)
In-Reply-To: <20230601-topic-sm8550-upstream-type-c-v3-5-22c9973012b6@linaro.org>
On 13/06/2023 09:55, Neil Armstrong wrote:
> Altmode is also supported for SM8550, allow it.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/soc/qcom/pmic_glink.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
> index c87056769ebd..8af06bdc6f5a 100644
> --- a/drivers/soc/qcom/pmic_glink.c
> +++ b/drivers/soc/qcom/pmic_glink.c
> @@ -342,13 +342,9 @@ static const unsigned long pmic_glink_sm8450_client_mask = BIT(PMIC_GLINK_CLIENT
> BIT(PMIC_GLINK_CLIENT_ALTMODE) |
> BIT(PMIC_GLINK_CLIENT_UCSI);
>
> -/* Do not handle altmode for now on those platforms */
> -static const unsigned long pmic_glink_sm8550_client_mask = BIT(PMIC_GLINK_CLIENT_BATT) |
> - BIT(PMIC_GLINK_CLIENT_UCSI);
> -
> static const struct of_device_id pmic_glink_of_match[] = {
> { .compatible = "qcom,sm8450-pmic-glink", .data = &pmic_glink_sm8450_client_mask },
Orientation and maybe all of the USB-related properties do not look like
sm8450 specific, but PM8350B. That's where CC_OUT pin is. I don't think
we represented this correctly, but rather copy-pasted downstream solution...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-13 11:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 7:55 [PATCH v3 0/8] arm64: qcom: add Type-C Altmode support Neil Armstrong
2023-06-13 7:55 ` [PATCH v3 1/8] dt-bindings: connector: usb-connector: add a gpio used to determine the Type-C port plug orientation Neil Armstrong
2023-06-13 8:13 ` Krzysztof Kozlowski
2023-06-13 8:54 ` Neil Armstrong
2023-06-13 9:02 ` Krzysztof Kozlowski
2023-06-13 9:24 ` neil.armstrong
2023-06-13 11:51 ` Krzysztof Kozlowski
2023-06-13 8:18 ` Rob Herring
2023-06-13 7:55 ` [PATCH v3 2/8] soc: qcom: pmic_glink_altmode: handle safe mode when disconnect Neil Armstrong
2023-06-26 9:18 ` Heikki Krogerus
2023-06-13 7:55 ` [PATCH v3 3/8] usb: ucsi: glink: use the connector orientation GPIO to provide switch events Neil Armstrong
2023-06-13 7:55 ` [PATCH v3 4/8] qcom: pmic_glink_altmode: add retimer-switch support Neil Armstrong
2023-06-26 9:19 ` Heikki Krogerus
2023-06-13 7:55 ` [PATCH v3 5/8] qcom: pmic_glink: enable altmode for SM8550 Neil Armstrong
2023-06-13 11:23 ` Konrad Dybcio
2023-06-13 11:54 ` Krzysztof Kozlowski [this message]
2023-06-13 13:43 ` Neil Armstrong
2023-06-13 13:58 ` Konrad Dybcio
2023-06-13 18:37 ` Krzysztof Kozlowski
2023-06-13 7:55 ` [PATCH v3 6/8] arm64: dts: qcom: sm8550: add ports subnodes in usb/dp qmpphy node Neil Armstrong
2023-06-13 7:56 ` [PATCH v3 7/8] arm64: dts: qcom: sm8550-mtp: add pmic glink port/endpoints Neil Armstrong
2023-06-13 7:56 ` [PATCH v3 8/8] arm64: dts: qcom: sm8550-qrd: " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5851627e-2972-f860-e965-dc8e73b01225@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.