Re: [PATCH 05/11] KVM: s390: Support Configuration z/Architecture Mode

From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>, KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>
Subject: Re: [PATCH 05/11] KVM: s390: Support Configuration z/Architecture Mode
Date: Mon, 28 Aug 2017 11:11:15 +0200	[thread overview]
Message-ID: <5865af6d-863f-f6b1-bc72-b2eec2ce953b@de.ibm.com> (raw)
In-Reply-To: <20170828110746.774d00e3.cohuck@redhat.com>

On 08/28/2017 11:07 AM, Cornelia Huck wrote:
> On Mon, 28 Aug 2017 10:07:28 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> 
>> From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
>>
>> kvm has always supported the concept of starting in z/Arch mode so let's
>> reflect the feature bit to the guest.
>>
>> Also, we change sigp set architecture to reject any request to change
>> architecture modes.
> 
> What are the implications of this for guests? IIRC, czam is a z14
> feature (the updated PoP is not yet out, is it?). We now reject any set
> arch sigp, even if we profess to be an older machine. Linux can
> probably deal with this, but is it correct?

Linux can deal with it. Since KVM does not support IPL in ESA mode, we basically
always provided the czam functionality. We now do it like it was architected.
z/VM does it the same way when enabling czam on an older system like z13.

In other words the old code was not compliant (and never was), the new code
is compliant. Since czam is kind of a "negative" facility, we can implement
it also on older systems.
> 
>>
>> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  arch/s390/kvm/sigp.c             | 36 +++++++++++++++++-------------------
>>  arch/s390/tools/gen_facilities.c |  1 +
>>  2 files changed, 18 insertions(+), 19 deletions(-)
> 