Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3

From: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Quentin Schulz
	<quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Subject: Re: [RFC PATCH v2 1/4] dt-bindings: update the Allwinner GPADC device tree binding for H3
Date: Thu, 06 Apr 2017 03:11:38 +0800	[thread overview]
Message-ID: <58e61093.8c9d810a.74942.1a49SMTPIN_ADDED_MISSING@gmr-mx.google.com> (raw)

2017年4月6日 03:04于 Rob Herring <robh@kernel.org>写道：
>
> On Tue, Apr 4, 2017 at 10:02 AM, Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> wrote: 
> > 
> > 
> > 在 2017年04月04日 22:47, Rob Herring 写道: 
> >> 
> >> On Sun, Apr 02, 2017 at 09:33:01PM +0800, Icenowy Zheng wrote: 
> >>> 
> >>> Allwinner H3 features a thermal sensor like the one in A33, but has its 
> >>> register re-arranged, the clock divider moved to CCU (originally the 
> >>> clock divider is in ADC) and added a pair of bus clock and reset. 
> >>> 
> >>> Update the binding document to cover H3. 
> >>> 
> >>> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> 
> >>> --- 
> >>>  .../devicetree/bindings/mfd/sun4i-gpadc.txt        | 23 
> >>> ++++++++++++++++++++-- 
> >>>  1 file changed, 21 insertions(+), 2 deletions(-) 
> >>> 
> >>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt 
> >>> b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt 
> >>> index badff3611a98..7753133ca0ff 100644 
> >>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt 
> >>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt 
> >>> @@ -4,12 +4,20 @@ The Allwinner SoCs all have an ADC that can also act as 
> >>> a thermal sensor 
> >>>  and sometimes as a touchscreen controller. 
> >>> 
> >>>  Required properties: 
> >>> -  - compatible: "allwinner,sun8i-a33-ths", 
> >>> +  - compatible: must contain one of the following compatibles: 
> >>> +               - "allwinner,sun8i-a33-ths" 
> >>> +               - "allwinner,sun8i-h3-ths" 
> >>>    - reg: mmio address range of the chip, 
> >>>    - #thermal-sensor-cells: shall be 0, 
> >>>    - #io-channel-cells: shall be 0, 
> >>> 
> >>> -Example: 
> >>> +Required properties for the following compatibles: 
> >>> +               - "allwinner,sun8i-h3-ths" 
> >>> +  - clocks: the bus clock and the input clock of the ADC, 
> >>> +  - clock-names: should be "bus" and "ths", 
> >>> +  - resets: the bus reset of the ADC, 
> >>> + 
> >>> +Example for A33: 
> >>>         ths: ths@01c25000 { 
> >>>                 compatible = "allwinner,sun8i-a33-ths"; 
> >>>                 reg = <0x01c25000 0x100>; 
> >>> @@ -17,6 +25,17 @@ Example: 
> >>>                 #io-channel-cells = <0>; 
> >>>         }; 
> >>> 
> >>> +Example for H3: 
> >>> +       ths: ths@01c25000 { 
> >> 
> >> 
> >> adc@... 
> > 
> > 
> > It's a thermal sensor, so I think call it THS is more appropriate 
> > here. It's implemented as an ADC driver just because the internal 
> > code reusing of Linux. From device tree binding view I choose to 
> > call it ths. 
>
> There's numerous occurrences in this file and the filename that call it an ADC. 
>
> Furthermore, node names are supposed to be generic, not part #'s or 
> whatever you decide to make up. So pick from adc or temperature-sensor 
> as those are the standard names . 

OK. I will make it :
ths: temperature-sensor@1c25000

(Calling it temperature sensor is according to the datasheet name)

>
> Rob 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.