From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v12 4/5] arm64: dts: qcom: ipq9574: Add LDO regulator node
Date: Wed, 7 Jun 2023 21:08:56 +0200 [thread overview]
Message-ID: <594582c6-6b20-7a44-a833-834c6e5eb9c6@linaro.org> (raw)
In-Reply-To: <1e795c18d6e19dbb5eebee357dddeb5022033825.1686045347.git.quic_varada@quicinc.com>
On 7.06.2023 12:48, Varadarajan Narayanan wrote:
> Add LDO regulator node
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> Changes in v10:
> - Add LDO regulator node
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> index 2b3ed8d..42d45e1 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
> @@ -45,6 +45,13 @@
> regulator-min-microvolt = <725000>;
> regulator-max-microvolt = <1075000>;
> };
> +
> + mp5496_l2: l2 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + regulator-always-on;
Nit: since it looks like you'll need to send another revision,
if you switched the order of the last two properties, it'd make
a nice reverse-Christmas-tree
Konrad
> + };
> };
> };
>
next prev parent reply other threads:[~2023-06-07 19:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 10:48 [PATCH v12 0/5] Enable IPQ9754 USB Varadarajan Narayanan
2023-06-07 10:48 ` [PATCH v12 1/5] dt-bindings: usb: dwc3: Add IPQ9574 compatible Varadarajan Narayanan
2023-06-07 10:48 ` [PATCH v12 2/5] clk: qcom: gcc-ipq9574: Add USB related clocks Varadarajan Narayanan
2023-06-07 10:48 ` [PATCH v12 3/5] arm64: dts: qcom: ipq9574: Add USB related nodes Varadarajan Narayanan
2023-06-07 11:07 ` Dmitry Baryshkov
2023-06-08 8:06 ` Varadarajan Narayanan
2023-06-07 18:50 ` Krzysztof Kozlowski
2023-06-08 8:10 ` Varadarajan Narayanan
2023-06-07 10:48 ` [PATCH v12 4/5] arm64: dts: qcom: ipq9574: Add LDO regulator node Varadarajan Narayanan
2023-06-07 19:08 ` Konrad Dybcio [this message]
2023-06-07 10:48 ` [PATCH v12 5/5] arm64: dts: qcom: ipq9574: Enable USB Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=594582c6-6b20-7a44-a833-834c6e5eb9c6@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.