From: alex chen <alex.chen@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/cluster: unlock the o2hb_live_lock before the o2nm_depend_item()
Date: Tue, 31 Oct 2017 20:41:39 +0800 [thread overview]
Message-ID: <59F86F83.7010501@huawei.com> (raw)
In the following situation, the down_write() will be called under
the spin_lock(), which may lead a soft lockup:
o2hb_region_inc_user
spin_lock(&o2hb_live_lock)
o2hb_region_pin
o2nm_depend_item
configfs_depend_item
inode_lock
down_write
-->here may sleep and reschedule
So we should unlock the o2hb_live_lock before the o2nm_depend_item(), and
get item reference in advance to prevent the region to be released.
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com>
Reviewed-by: Jun Piao <piaojun@huawei.com>
---
fs/ocfs2/cluster/heartbeat.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
index d020604..f1142a9 100644
--- a/fs/ocfs2/cluster/heartbeat.c
+++ b/fs/ocfs2/cluster/heartbeat.c
@@ -2399,6 +2399,9 @@ static int o2hb_region_pin(const char *region_uuid)
if (reg->hr_item_pinned || reg->hr_item_dropped)
goto skip_pin;
+ config_item_get(®->hr_item);
+ spin_unlock(&o2hb_live_lock);
+
/* Ignore ENOENT only for local hb (userdlm domain) */
ret = o2nm_depend_item(®->hr_item);
if (!ret) {
@@ -2410,9 +2413,14 @@ static int o2hb_region_pin(const char *region_uuid)
else {
mlog(ML_ERROR, "Pin region %s fails with %d\n",
uuid, ret);
+ config_item_put(®->hr_item);
+ spin_lock(&o2hb_live_lock);
break;
}
}
+
+ config_item_put(®->hr_item);
+ spin_lock(&o2hb_live_lock);
skip_pin:
if (found)
break;
-- 1.9.5.msysgit.1
next reply other threads:[~2017-10-31 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 12:41 alex chen [this message]
2017-11-01 1:03 ` [Ocfs2-devel] [PATCH] ocfs2/cluster: unlock the o2hb_live_lock before the o2nm_depend_item() Joseph Qi
2017-11-01 1:14 ` Changwei Ge
2017-11-01 7:01 ` alex chen
2017-11-01 8:28 ` Changwei Ge
2017-11-01 9:47 ` alex chen
2017-11-01 9:59 ` Changwei Ge
2017-11-02 3:43 ` alex chen
2017-11-02 5:58 ` Changwei Ge
2017-11-02 10:50 ` alex chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59F86F83.7010501@huawei.com \
--to=alex.chen@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.