From: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: alexander.deucher-5C7GfCeVMHo@public.gmane.org,
David1.Zhou-5C7GfCeVMHo@public.gmane.org,
christian.koenig-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing
Date: Tue, 17 Apr 2018 17:13:48 -0400 [thread overview]
Message-ID: <59bb29d9-da0c-1542-88bf-71bed96f3ed2@codeaurora.org> (raw)
In-Reply-To: <622c9ac3784170880dbde6900146e68631df958a.1523977133.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
On 4/17/2018 11:58 AM, Robin Murphy wrote:
> The amdgpu driver doesn't appear to directly use the scatterlist mapped
> by amdgpu_ttm_tt_pin_userptr(), it merely hands it off to
> drm_prime_sg_to_page_addr_arrays() to generate the dma_address array
> which it actually cares about. Now that the latter can cope with
> dma_map_sg() coalescing dma-contiguous segments such that it returns
> 0 < count < nents, we can relax the current count == nents check to
> only consider genuine failure as other drivers do.
>
> This avoids a false negative on arm64 systems with an IOMMU.
>
> Reported-by: Sinan Kaya <okaya@codeaurora.org>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> v2: Expand commit message to clarify
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 205da3ff9cd0..f81e96a4242f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -813,7 +813,7 @@ static int amdgpu_ttm_tt_pin_userptr(struct ttm_tt *ttm)
>
> r = -ENOMEM;
> nents = dma_map_sg(adev->dev, ttm->sg->sgl, ttm->sg->nents, direction);
> - if (nents != ttm->sg->nents)
> + if (nents == 0)
> goto release_sg;
>
> drm_prime_sg_to_page_addr_arrays(ttm->sg, ttm->pages,
>
Tested-by: Sinan Kaya <okaya@codeaurora.org>
using QDF2400 and XFX Vega64 GPU for the first two patches.
./builddir/tests/amdgpu/amdgpu_test -s 1
Suite: Basic Tests
Test: Userptr Test ...passed
Userptr Test fails without this patch.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-04-17 21:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 15:58 [PATCH v2 1/3] drm/prime: Iterate SG DMA addresses separately Robin Murphy
2018-04-17 15:58 ` [PATCH v2 2/3] drm/amdgpu: Allow dma_map_sg() coalescing Robin Murphy
[not found] ` <622c9ac3784170880dbde6900146e68631df958a.1523977133.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-04-17 21:13 ` Sinan Kaya [this message]
[not found] ` <59bb29d9-da0c-1542-88bf-71bed96f3ed2-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-04-25 20:44 ` Sinan Kaya
2018-04-27 15:54 ` Robin Murphy
2018-04-27 16:20 ` Sinan Kaya
2018-04-27 19:42 ` Sinan Kaya
2018-04-30 13:00 ` Robin Murphy
2018-04-17 15:58 ` [PATCH v2 3/3] drm/radeon: " Robin Murphy
2018-04-17 16:29 ` [PATCH v2 1/3] drm/prime: Iterate SG DMA addresses separately Christian König
2018-04-17 18:22 ` Robin Murphy
[not found] ` <73ac5c65-1dbd-8711-5770-75d79389bf44-5wv7dgnIgG8@public.gmane.org>
2018-04-17 18:25 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59bb29d9-da0c-1542-88bf-71bed96f3ed2@codeaurora.org \
--to=okaya-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=David1.Zhou-5C7GfCeVMHo@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.