From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Simon Horman <simon.horman@corigine.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] 3c589_cs: Fix an error handling path in tc589_probe()
Date: Mon, 22 May 2023 19:18:29 +0200 [thread overview]
Message-ID: <59ca8e12-a4ab-7f5b-68ba-fe04683b3cf5@wanadoo.fr> (raw)
In-Reply-To: <ZGthVr9FppjWDA9F@corigine.com>
Le 22/05/2023 à 14:34, Simon Horman a écrit :
> On Sat, May 20, 2023 at 11:48:55AM +0200, Christophe JAILLET wrote:
>> Should tc589_config() fail, some resources need to be released as already
>> done in the remove function.
>>
>> Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
>
> That commit is probably going back far enough, but I actually
> suspect the problem has been there since the beginning of git history.
In fact, before that commit, the probe was always returning 0, so there
was no need for an error handling path.
FYI, commit 15b99ac17295 ("[PATCH] pcmcia: add return value to _config()
functions") messed up many drivers for the same reason.
I sent a few patches to see if there was an interest to fix these
(really) old drivers, most linked with pcmcia which seems to slowly be
removed from the kernel.
So I'm a bit unsure if fixing it really matters.
Let see if I collect some other R-b tags for the other patches.
CJ
>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
>
>
next prev parent reply other threads:[~2023-05-22 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 9:48 [PATCH net] 3c589_cs: Fix an error handling path in tc589_probe() Christophe JAILLET
2023-05-22 12:34 ` Simon Horman
2023-05-22 17:18 ` Christophe JAILLET [this message]
2023-05-23 8:42 ` Simon Horman
2023-05-23 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ca8e12-a4ab-7f5b-68ba-fe04683b3cf5@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.