RE: [PATCH v3 02/11] OMAP3: PM: Adding voltage driver support for OMAP3

From: "Gopinath, Thara" <thara@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"paul@pwsan.com" <paul@pwsan.com>,
	"Cousson, Benoit" <b-cousson@ti.com>,
	"Sripathy, Vishwanath" <vishwanath.bs@ti.com>,
	"Sawant, Anand" <sawant@ti.com>
Subject: RE: [PATCH v3 02/11] OMAP3: PM: Adding voltage driver support for OMAP3
Date: Fri, 22 Oct 2010 19:53:39 +0530	[thread overview]
Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB035EB95E9D@dbde02.ent.ti.com> (raw)
In-Reply-To: <1287079505.14514.55.camel@localhost>

>>-----Original Message-----
>>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>>owner@vger.kernel.org] On Behalf Of Kevin Hilman
>>Sent: Thursday, October 14, 2010 11:35 PM
>>To: Gopinath, Thara
>>Cc: linux-omap@vger.kernel.org; paul@pwsan.com; Cousson, Benoit; Sripathy,
>>Vishwanath; Sawant, Anand
>>Subject: Re: [PATCH v3 02/11] OMAP3: PM: Adding voltage driver support for
>>OMAP3
>>
>>On Wed, 2010-09-22 at 20:15 +0530, Thara Gopinath wrote:
>>> This patch adds voltage driver support for OMAP3. The driver
>>> allows  configuring the voltage controller and voltage
>>> processors during init and exports APIs to enable/disable
>>> voltage processors, scale voltage and reset voltage.
>>> The driver also maintains the global voltage table on a per
>>> VDD basis which contains the various voltages supported by the
>>> VDD along with per voltage dependent data like smartreflex
>>> n-target value, errminlimit and voltage processor errorgain.
>>> The driver allows scaling of VDD voltages either through
>>> "vc bypass method" or through "vp forceupdate method" the
>>> choice being configurable through the board file.
>>>
>>> This patch contains code originally in linux omap pm branch
>>> smartreflex driver.  Major contributors to this driver are
>>> Lesly A M, Rajendra Nayak, Kalle Jokiniemi, Paul Walmsley,
>>> Nishant Menon, Kevin Hilman.
>>>
>>> Signed-off-by: Thara Gopinath <thara@ti.com>
>>
>>[...]
>>
>>> +/*
>>> + * Omap3630 specific VP register values. Maybe these need to come from
>>> + * board file or PMIC data structure
>>> + */
>>> +#define OMAP3630_VP1_VLIMITTO_VDDMIN		0x18
>>> +#define OMAP3630_VP1_VLIMITTO_VDDMAX		0x3C
>>> +#define OMAP3630_VP2_VLIMITTO_VDDMIN		0x18
>>> +#define OMAP3630_VP2_VLIMITTO_VDDMAX		0x30
>>> +
>>> +/* TODO OMAP4 VP register values if the same file is used for OMAP4*/
>>> +
>>> +/**
>>> + * voltagedomain - omap voltage domain global structure
>>> + * @name       : Name of the voltage domain which can be used as a unique
>>> + *               identifier.
>>> + */
>>> +struct voltagedomain {
>>> +	char *name;
>>> +};
>>
>>Minor: to keep the voltagedomain stuff somewhat separate from the rest
>>of the voltage layer API, I suggest putting the voltage domain APIs
>>here:
>>
>>struct voltagedomain *omap_voltage_domain_get(char *name);

You mean just move up the signature, right? I do not think the entire API can be moved here as it uses some static data structures in voltage.c

>>
>>However, I think this function shoul be called _lookup instead of _get
>>to continue the naming conventions of the powerdomain and clockdomain
>>code.

I will rename the API.

Regards
Thara
>>
>>Kevin
>>
>>
>>--
>>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>the body of a message to majordomo@vger.kernel.org
>>More majordomo info at  http://vger.kernel.org/majordomo-info.html