From: Chanwoo Choi <cw00.choi@samsung.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH] extcon: int3496: use proper GPIO include
Date: Fri, 13 Apr 2018 10:13:54 +0900 [thread overview]
Message-ID: <5AD00452.5060400@samsung.com> (raw)
In-Reply-To: <5AD0032E.6020103@samsung.com>
On 2018년 04월 13일 10:09, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 04월 10일 21:43, Wolfram Sang wrote:
>> Since commit eca0f13c836a ("extcon: int3496: Ignore incorrect
>> IoRestriction for ID pin"), the driver doesn't use GPIOF_* flags
>> anymore. We can thus now drop the deprecated include file for GPIO and
>> use the new one.
>
> Looks good to me. But, you need to send stable mailing list
> and add 'Fixes' tag on v2.
You don't need to send stable mailing list. It is my mistake.
Just I'll pick this patch on extcon-fixes branch.
>
>>
>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> ---
>>
>> Compile tested only.
>>
>> @linusw: one more gone
>>
>> drivers/extcon/extcon-intel-int3496.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
>> index acaccb128fc4..fd24debe58a3 100644
>> --- a/drivers/extcon/extcon-intel-int3496.c
>> +++ b/drivers/extcon/extcon-intel-int3496.c
>> @@ -20,7 +20,7 @@
>>
>> #include <linux/acpi.h>
>> #include <linux/extcon-provider.h>
>> -#include <linux/gpio.h>
>> +#include <linux/gpio/consumer.h>
>> #include <linux/interrupt.h>
>> #include <linux/module.h>
>> #include <linux/platform_device.h>
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2018-04-13 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180410124315epcas5p39971522b55337b5c1369883f128ff43c@epcas5p3.samsung.com>
2018-04-10 12:43 ` [PATCH] extcon: int3496: use proper GPIO include Wolfram Sang
2018-04-13 1:09 ` Chanwoo Choi
2018-04-13 1:13 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AD00452.5060400@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.