From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/132: umount scratch device after finishing test
Date: Mon, 21 May 2018 15:45:52 +0800 [thread overview]
Message-ID: <5B027930.4050203@cn.fujitsu.com> (raw)
In-Reply-To: <20180521023631.GN10363@dastard>
On 2018/05/21 10:36, Dave Chinner wrote:
> On Sat, May 19, 2018 at 12:32:24PM +0800, Xiao Yang wrote:
>> xfs/132 and xfs/133 running together got the following error:
>> ------------------------------------------------------------
>> ...
>> xfs/132 1s ... 1s
>> xfs/133 1s ... [failed, exit status 1] - output mismatch (see /var/lib/xfstests/results//xfs/133.out.bad)
>> ...
>> QA output created by 133
>> -Format and mount
>> -Corrupt filesystem
>> -Remount, try to append
>> -Write did not succeed (ok).
>> +SCRATCH_DEV=/dev/sda11 is mounted but not on SCRATCH_MNT=common/config: - aborting
>> +Already mounted result:
>> +/dev/sda11 /mnt/xfstests/scratch
>> ...
>> ------------------------------------------------------------
>>
>> xfs/132 led to XFS shutdown due to the corrupted inode, but it didn't rectify XFS
>> by umount scratch device.
> AFAIK, we don't have to unmount the scratch device when a test
> finishes - the test harness is supposed to do that and make sure
> that it is in the correct state for the next test to run.
>
> It seems that somewhere along the line this got broken. - I'm
> guessing the fact that this test also says "don't check the scratch
> device" the test harness is failing to unmount it because it's not
> running _check_scratch_device. I'm guessing that it should at least
> run _scratch_unmount....
Hi Dave,
Could we just make the test harness call _scratch_unmount after running every test, as below:
--------------------------------------------------------------
diff --git a/check b/check
index 96198ac..63ece67 100755
--- a/check
+++ b/check
@@ -815,6 +815,7 @@ for section in $HOST_OPTIONS_SECTIONS; do
_make_testcase_report "$tc_status"
fi
seq="after_$seqnum"
+ _scratch_unmount 2> /dev/null
done
sect_stop=`_wallclock`
interrupt=false
@@ -823,7 +824,6 @@ for section in $HOST_OPTIONS_SECTIONS; do
echo
_test_unmount 2> /dev/null
- _scratch_unmount 2> /dev/null
done
interrupt=false
---------------------------------------------------------------
Thanks,
Xiao Yang
> Cheers,
>
> Dave.
next prev parent reply other threads:[~2018-05-21 7:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 4:32 [PATCH] xfs/132: umount scratch device after finishing test Xiao Yang
2018-05-21 2:36 ` Dave Chinner
2018-05-21 7:45 ` Xiao Yang [this message]
2018-05-21 22:46 ` Dave Chinner
2018-05-22 4:06 ` Xiao Yang
2018-05-22 5:19 ` Dave Chinner
2018-05-22 6:03 ` [PATCH v2] check: Make the test harness unmount fs when finishing a test Xiao Yang
2018-05-22 9:49 ` [PATCH v3] " Xiao Yang
2018-05-22 22:14 ` Dave Chinner
2018-05-22 9:57 ` [PATCH v2] " Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B027930.4050203@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.