From: Georgi Djakov <georgi.djakov@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/6] interconnect: qcom: Add SM8250 interconnect provider driver
Date: Mon, 13 Jul 2020 16:30:21 +0300 [thread overview]
Message-ID: <5a0eca0e-d496-d8af-ca41-0f07e9a3e01d@linaro.org> (raw)
In-Reply-To: <20200701134259.8055-5-jonathan@marek.ca>
Hi Jonathan,
Thanks for posting these patches!
On 7/1/20 16:42, Jonathan Marek wrote:
> Add driver for the Qualcomm interconnect buses found in SM8250 based
> platforms. The topology consists of several NoCs that are controlled by
> a remote processor that collects the aggregated bandwidth for each
> master-slave pairs.
>
> Based on SC7180 driver and generated from downstream dts.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
[..]
> +
> +static const struct of_device_id qnoc_of_match[] = {
> + { .compatible = "qcom,sm8250-aggre1-noc",
> + .data = &sm8250_aggre1_noc},
> + { .compatible = "qcom,sm8250-aggre2-noc",
> + .data = &sm8250_aggre2_noc},
> + { .compatible = "qcom,sm8250-compute-noc",
> + .data = &sm8250_compute_noc},
> + { .compatible = "qcom,sm8250-config-noc",
> + .data = &sm8250_config_noc},
> + { .compatible = "qcom,sm8250-dc-noc",
> + .data = &sm8250_dc_noc},
> + { .compatible = "qcom,sm8250-gem-noc",
> + .data = &sm8250_gem_noc},
> + { .compatible = "qcom,sm8250-ipa-virt",
> + .data = &sm8250_ipa_virt},
> + { .compatible = "qcom,sm8250-mc-virt",
> + .data = &sm8250_mc_virt},
> + { .compatible = "qcom,sm8250-mmss-noc",
> + .data = &sm8250_mmss_noc},
> + { .compatible = "qcom,sm8250-npu-noc",
> + .data = &sm8250_npu_noc},
> + { .compatible = "qcom,sm8250-system-noc",
> + .data = &sm8250_system_noc},
> + { .compatible = "qcom,sm8250-gem-noc-display",
> + .data = &sm8250_gem_noc_display},
> + { .compatible = "qcom,sm8250-mc-virt-display",
> + .data = &sm8250_mc_virt_display},
> + { .compatible = "qcom,sm8250-mmss-noc-display",
> + .data = &sm8250_mmss_noc_display},
> + { }
My main concern here are the display RSC nodes. We should not add the nodes
for voting on the display RSC, but use the "qcom,bcm-voters" property in DT
to list both "hlos" and "disp" as bcm voters for gem-noc, mc-virt and
mmss-noc.
Thanks,
Georgi
next prev parent reply other threads:[~2020-07-13 13:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 13:42 [PATCH 0/6] Add SM8150 and SM8250 interconnect drivers Jonathan Marek
2020-07-01 13:42 ` [PATCH 1/6] dt-bindings: interconnect: Add Qualcomm SM8150 DT bindings Jonathan Marek
2020-07-02 20:48 ` Rob Herring
2020-07-01 13:42 ` [PATCH 2/6] dt-bindings: interconnect: Add Qualcomm SM8250 " Jonathan Marek
2020-07-02 20:49 ` Rob Herring
2020-07-02 20:49 ` Rob Herring
2020-07-01 13:42 ` [PATCH 3/6] interconnect: qcom: Add SM8150 interconnect provider driver Jonathan Marek
2020-07-01 13:42 ` [PATCH 4/6] interconnect: qcom: Add SM8250 " Jonathan Marek
2020-07-13 13:30 ` Georgi Djakov [this message]
2020-07-13 13:47 ` Jonathan Marek
2020-07-13 14:19 ` Georgi Djakov
2020-07-01 13:42 ` [PATCH 5/6] arm64: dts: qcom: sm8150: add interconnect nodes Jonathan Marek
2020-07-01 13:42 ` [PATCH 6/6] arm64: dts: qcom: sm8250: " Jonathan Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a0eca0e-d496-d8af-ca41-0f07e9a3e01d@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.